RESOLVED FIXED Bug 235838
[macOS] Expose screen and window capture state to WKWebView 
https://bugs.webkit.org/show_bug.cgi?id=235838
Summary [macOS] Expose screen and window capture state to WKWebView
Eric Carlson
Reported 2022-01-28 15:08:20 PST
Expose screen and window capture state to WKWebView
Attachments
Patch (85.27 KB, patch)
2022-01-28 16:23 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (82.23 KB, patch)
2022-01-31 11:52 PST, Eric Carlson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (84.50 KB, patch)
2022-01-31 13:08 PST, Eric Carlson 		youennf: review+
DetailsFormatted DiffDiff
Patch for landing (84.68 KB, patch)
2022-01-31 14:32 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (86.60 KB, patch)
2022-01-31 16:45 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (85.53 KB, patch)
2022-02-01 08:56 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-01-28 15:41:43 PST
<rdar://problem/88207924>
Eric Carlson
Comment 2 2022-01-28 16:23:18 PST
Created attachment 450287 [details] Patch
Eric Carlson
Comment 3 2022-01-31 11:52:42 PST
Created attachment 450426 [details] Patch
EWS Watchlist
Comment 4 2022-01-31 11:54:39 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Eric Carlson
Comment 5 2022-01-31 13:08:40 PST
Created attachment 450439 [details] Patch
youenn fablet
Comment 6 2022-01-31 14:15:16 PST
Comment on attachment 450439 [details] Patch Probably worth adding a test validating we delay with a timer the start capture/stop capture. While this is mostly useful for camera, it is good to validate this will work for display as well. Another question worth exploring. We might add in the future getViewPortMedia which is specific to capturing the self tab. We probably want a different delegate, but it may be ok to keep the same display states/mutators APIs. Wdyt? View in context: https://bugs.webkit.org/attachment.cgi?id=450439&action=review > Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:4873 > + UNUSED_PARAM(isFromDisplayCapture); FIXME: Remove isFromDisplayCapture?
Eric Carlson
Comment 7 2022-01-31 14:28:32 PST
(In reply to youenn fablet from comment #6) > Comment on attachment 450439 [details] > Patch > > Probably worth adding a test validating we delay with a timer the start > capture/stop capture. > While this is mostly useful for camera, it is good to validate this will > work for display as well. > > Another question worth exploring. We might add in the future > getViewPortMedia which is specific to capturing the self tab. > We probably want a different delegate, but it may be ok to keep the same > display states/mutators APIs. > Wdyt? > Seems reasonable. > View in context: > https://bugs.webkit.org/attachment.cgi?id=450439&action=review > > > Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:4873 > > + UNUSED_PARAM(isFromDisplayCapture); > > FIXME: Remove isFromDisplayCapture? Good idea, I'll do that.
Eric Carlson
Comment 8 2022-01-31 14:32:28 PST
Created attachment 450466 [details] Patch for landing
Eric Carlson
Comment 9 2022-01-31 16:45:07 PST
Created attachment 450473 [details] Patch
Eric Carlson
Comment 10 2022-02-01 08:56:50 PST
Created attachment 450536 [details] Patch for landing
EWS
Comment 11 2022-02-01 10:35:31 PST
Committed r288894 (246639@main): <https://commits.webkit.org/246639@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450536 [details].
Note You need to log in before you can comment on or make changes to this bug.