Bug 236094 - Add a helper method on VideoFullscreenManagerProxy to request video frame data
Summary: Add a helper method on VideoFullscreenManagerProxy to request video frame data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on: 236090
Blocks: 236100
  Show dependency treegraph
 
Reported: 2022-02-03 11:05 PST by Wenson Hsieh
Modified: 2022-02-07 08:04 PST (History)
11 users (show)

See Also:


Attachments
Depends on #236090 (11.31 KB, patch)
2022-02-03 11:16 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Depends on #236090 (11.31 KB, patch)
2022-02-03 16:58 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2022-02-03 11:05:12 PST
.
Comment 1 Wenson Hsieh 2022-02-03 11:16:06 PST
Created attachment 450800 [details]
Depends on #236090
Comment 2 Eric Carlson 2022-02-03 14:54:15 PST
Comment on attachment 450800 [details]
Depends on #236090

View in context: https://bugs.webkit.org/attachment.cgi?id=450800&action=review

> Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:533
> +    auto* gpuProcess = GPUProcessProxy::singletonIfCreated();
> +    if (!gpuProcess) {
> +        completionHandler({ });
> +        return;
> +    }

Nit: you might want to do this first because there's no need to find the interface of player unless the GPUP is running.
Comment 3 Wenson Hsieh 2022-02-03 16:56:23 PST
(In reply to Eric Carlson from comment #2)
> Comment on attachment 450800 [details]
> Depends on #236090
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450800&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:533
> > +    auto* gpuProcess = GPUProcessProxy::singletonIfCreated();
> > +    if (!gpuProcess) {
> > +        completionHandler({ });
> > +        return;
> > +    }
> 
> Nit: you might want to do this first because there's no need to find the
> interface of player unless the GPUP is running.

Good point! Moved this check/early return to the top.
Comment 4 Wenson Hsieh 2022-02-03 16:58:05 PST
Created attachment 450838 [details]
Depends on #236090
Comment 5 Wenson Hsieh 2022-02-07 07:47:46 PST
Comment on attachment 450838 [details]
Depends on #236090

Thanks for the review!
Comment 6 EWS 2022-02-07 08:03:08 PST
Committed r289221 (246906@main): <https://commits.webkit.org/246906@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450838 [details].
Comment 7 Radar WebKit Bug Importer 2022-02-07 08:04:18 PST
<rdar://problem/88572213>