Bug 236094 – Add a helper method on VideoFullscreenManagerProxy to request video frame data

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Wenson Hsieh]

.

[Wenson Hsieh]

Created attachment 450800 [details]
Depends on #236090

[Eric Carlson]

Comment on attachment 450800 [details]
Depends on #236090

View in context: https://bugs.webkit.org/attachment.cgi?id=450800&action=review

> Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:533
> +    auto* gpuProcess = GPUProcessProxy::singletonIfCreated();
> +    if (!gpuProcess) {
> +        completionHandler({ });
> +        return;
> +    }

Nit: you might want to do this first because there's no need to find the interface of player unless the GPUP is running.

[Wenson Hsieh]

(In reply to Eric Carlson from comment #2)
> Comment on attachment 450800 [details]
> Depends on #236090
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450800&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:533
> > +    auto* gpuProcess = GPUProcessProxy::singletonIfCreated();
> > +    if (!gpuProcess) {
> > +        completionHandler({ });
> > +        return;
> > +    }
> 
> Nit: you might want to do this first because there's no need to find the
> interface of player unless the GPUP is running.

Good point! Moved this check/early return to the top.

[Wenson Hsieh]

Created attachment 450838 [details]
Depends on #236090

[Wenson Hsieh]

Comment on attachment 450838 [details]
Depends on #236090

Thanks for the review!

[EWS]

Committed r289221 (246906@main): <https://commits.webkit.org/246906@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450838 [details].

[Radar WebKit Bug Importer]

<rdar://problem/88572213>