Bug 236090 - Teach VideoFullscreenInterface to keep track of its corresponding MediaPlayer's MediaPlayerIdentifier
Summary: Teach VideoFullscreenInterface to keep track of its corresponding MediaPlayer...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks: 236094
  Show dependency treegraph
 
Reported: 2022-02-03 09:48 PST by Wenson Hsieh
Modified: 2022-02-03 18:48 PST (History)
10 users (show)

See Also:


Attachments
For EWS (18.60 KB, patch)
2022-02-03 10:43 PST, Wenson Hsieh
eric.carlson: review+
Details | Formatted Diff | Diff
For landing (18.65 KB, patch)
2022-02-03 16:55 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2022-02-03 09:48:16 PST
.
Comment 1 Wenson Hsieh 2022-02-03 10:43:53 PST
Created attachment 450795 [details]
For EWS
Comment 2 Wenson Hsieh 2022-02-03 16:21:10 PST
Comment on attachment 450795 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=450795&action=review

Thanks for the review!

> Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm:320
> +        setPlayerIdentifier(contextId, player->identifier());

Ah, so after a bit more testing, I discovered is that this breaks fullscreen media in WebKit2 in the case where the GPUP: Media flag is off, since it tries to send an invalid (0) ObjectIdentifier across the process boundary :P I'll add a check for here to guard against this case.
Comment 3 Wenson Hsieh 2022-02-03 16:55:09 PST
Created attachment 450837 [details]
For landing
Comment 4 EWS 2022-02-03 18:46:59 PST
Committed r289100 (246797@main): <https://commits.webkit.org/246797@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450837 [details].
Comment 5 Radar WebKit Bug Importer 2022-02-03 18:48:17 PST
<rdar://problem/88468414>