Bug 235867 – Delete code for keygen element

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Ryosuke Niwa]

keygen element is dead.

[Ryosuke Niwa]

Created attachment 450341 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Darin Adler]

Comment on attachment 450341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450341&action=review

r=me, no idea why tests are failing, but we have to deal with that.

> Source/WebCore/bindings/js/WebCoreBuiltinNames.h:-177
> -    macro(HTMLSlotElement) \

This change isn’t mentioned in the change log. Maybe a good idea, but I don’t see the explanation.

> Source/WebKit/UIProcess/API/C/WKPreferences.cpp:2086
> +    return true;

Maybe false is better?

[Ryosuke Niwa]

(In reply to Darin Adler from comment #3)
> Comment on attachment 450341 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450341&action=review
> 
> r=me, no idea why tests are failing, but we have to deal with that.
> 
> > Source/WebCore/bindings/js/WebCoreBuiltinNames.h:-177
> > -    macro(HTMLSlotElement) \
> 
> This change isn’t mentioned in the change log. Maybe a good idea, but I
> don’t see the explanation.

Oh oops, I forgot to mention that. This was also never used. It's a left over from when we had a runtime flag to enable shadow DOM. Will mention in the change log.

> > Source/WebKit/UIProcess/API/C/WKPreferences.cpp:2086
> > +    return true;
> 
> Maybe false is better?

Good point. Will fix.

[Ryosuke Niwa]

Created attachment 450351 [details]
Patch

[Ryosuke Niwa]

Created attachment 450352 [details]
Updated the tests

[Ryosuke Niwa]

Created attachment 450356 [details]
Rebaselined one more test

[Antti Koivisto]

Comment on attachment 450356 [details]
Rebaselined one more test

View in context: https://bugs.webkit.org/attachment.cgi?id=450356&action=review

> Source/WebCore/ChangeLog:3
> +        Delete runtime preference for enabling keygen element

This deletes the code as well, could mention that in the title.

[Ryosuke Niwa]

(In reply to Antti Koivisto from comment #8)
> Comment on attachment 450356 [details]
> Rebaselined one more test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450356&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Delete runtime preference for enabling keygen element
> 
> This deletes the code as well, could mention that in the title.

Sure.

[Ryosuke Niwa]

Created attachment 450367 [details]
Patch for landing

[Ryosuke Niwa]

Created attachment 450369 [details]
Patch for landing

[EWS]

Committed r288804 (246580@main): <https://commits.webkit.org/246580@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450369 [details].

[Radar WebKit Bug Importer]

<rdar://problem/88250952>

[Truitt Savell]

It looks like the changes in https://trac.webkit.org/changeset/288804/webkit

broke this test on wk2 for all of Mac

tracking in https://bugs.webkit.org/show_bug.cgi?id=236325

[Darin Adler]

*** Bug 167018 has been marked as a duplicate of this bug. ***