Bug 235867 - Delete code for keygen element
Summary: Delete code for keygen element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
: 167018 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-01-29 15:09 PST by Ryosuke Niwa
Modified: 2022-07-29 16:12 PDT (History)
34 users (show)

See Also:


Attachments
Patch (45.42 KB, patch)
2022-01-29 15:17 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch (150.66 KB, patch)
2022-01-29 22:04 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Updated the tests (151.33 KB, patch)
2022-01-29 22:15 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Rebaselined one more test (151.89 KB, patch)
2022-01-29 23:02 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (152.57 KB, patch)
2022-01-30 13:28 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (154.18 KB, patch)
2022-01-30 14:33 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2022-01-29 15:09:41 PST
keygen element is dead.
Comment 1 Ryosuke Niwa 2022-01-29 15:17:02 PST
Created attachment 450341 [details]
Patch
Comment 2 EWS Watchlist 2022-01-29 15:19:00 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Darin Adler 2022-01-29 16:44:53 PST
Comment on attachment 450341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450341&action=review

r=me, no idea why tests are failing, but we have to deal with that.

> Source/WebCore/bindings/js/WebCoreBuiltinNames.h:-177
> -    macro(HTMLSlotElement) \

This change isn’t mentioned in the change log. Maybe a good idea, but I don’t see the explanation.

> Source/WebKit/UIProcess/API/C/WKPreferences.cpp:2086
> +    return true;

Maybe false is better?
Comment 4 Ryosuke Niwa 2022-01-29 20:41:37 PST
(In reply to Darin Adler from comment #3)
> Comment on attachment 450341 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450341&action=review
> 
> r=me, no idea why tests are failing, but we have to deal with that.
> 
> > Source/WebCore/bindings/js/WebCoreBuiltinNames.h:-177
> > -    macro(HTMLSlotElement) \
> 
> This change isn’t mentioned in the change log. Maybe a good idea, but I
> don’t see the explanation.

Oh oops, I forgot to mention that. This was also never used. It's a left over from when we had a runtime flag to enable shadow DOM. Will mention in the change log.

> > Source/WebKit/UIProcess/API/C/WKPreferences.cpp:2086
> > +    return true;
> 
> Maybe false is better?

Good point. Will fix.
Comment 5 Ryosuke Niwa 2022-01-29 22:04:19 PST
Created attachment 450351 [details]
Patch
Comment 6 Ryosuke Niwa 2022-01-29 22:15:14 PST
Created attachment 450352 [details]
Updated the tests
Comment 7 Ryosuke Niwa 2022-01-29 23:02:59 PST
Created attachment 450356 [details]
Rebaselined one more test
Comment 8 Antti Koivisto 2022-01-30 07:44:41 PST
Comment on attachment 450356 [details]
Rebaselined one more test

View in context: https://bugs.webkit.org/attachment.cgi?id=450356&action=review

> Source/WebCore/ChangeLog:3
> +        Delete runtime preference for enabling keygen element

This deletes the code as well, could mention that in the title.
Comment 9 Ryosuke Niwa 2022-01-30 13:16:59 PST
(In reply to Antti Koivisto from comment #8)
> Comment on attachment 450356 [details]
> Rebaselined one more test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450356&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Delete runtime preference for enabling keygen element
> 
> This deletes the code as well, could mention that in the title.

Sure.
Comment 10 Ryosuke Niwa 2022-01-30 13:28:21 PST
Created attachment 450367 [details]
Patch for landing
Comment 11 Ryosuke Niwa 2022-01-30 14:33:17 PST
Created attachment 450369 [details]
Patch for landing
Comment 12 EWS 2022-01-30 19:59:47 PST
Committed r288804 (246580@main): <https://commits.webkit.org/246580@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450369 [details].
Comment 13 Radar WebKit Bug Importer 2022-01-30 20:00:18 PST
<rdar://problem/88250952>
Comment 14 Truitt Savell 2022-02-08 13:27:51 PST
It looks like the changes in https://trac.webkit.org/changeset/288804/webkit

broke this test on wk2 for all of Mac

tracking in https://bugs.webkit.org/show_bug.cgi?id=236325
Comment 15 Darin Adler 2022-07-29 16:12:22 PDT
*** Bug 167018 has been marked as a duplicate of this bug. ***