Bug 235857 - Add PushService
Summary: Add PushService
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on: 234194 235855 235856 236264
Blocks:
  Show dependency tree / graph
 
Reported: 2022-01-28 23:46 PST by Ben Nham
Modified: 2022-02-14 11:25 PST (History)
9 users (show)

See Also:

Attachments
Patch (86.22 KB, patch)
2022-01-28 23:48 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
rebase (86.22 KB, patch)
2022-01-30 22:52 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
rebase (86.25 KB, patch)
2022-01-31 13:49 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
add tests for different payload types (90.83 KB, patch)
2022-02-01 14:21 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
rebase (90.97 KB, patch)
2022-02-05 15:31 PST, Ben Nham 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
rebase (91.00 KB, patch)
2022-02-05 16:00 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Patch for landing (91.00 KB, patch)
2022-02-07 11:56 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Patch for landing (91.00 KB, patch)
2022-02-07 12:05 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Patch for landing (91.03 KB, patch)
2022-02-07 13:19 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Patch for landing (91.16 KB, patch)
2022-02-07 17:22 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Show Obsolete (9) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2022-01-28 23:46:24 PST 
Add PushService
Comment 1 Ben Nham 2022-01-28 23:48:28 PST 
Created attachment 450321 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-01-28 23:50:18 PST 
<rdar://problem/88219139>
Comment 3 Ben Nham 2022-01-30 22:52:26 PST 
Created attachment 450382 [details]
rebase
Comment 4 Ben Nham 2022-01-31 13:49:31 PST 
Created attachment 450455 [details]
rebase
Comment 5 Ben Nham 2022-02-01 14:21:47 PST 
Created attachment 450567 [details]
add tests for different payload types
Comment 6 Ben Nham 2022-02-05 15:31:13 PST 
Created attachment 451003 [details]
rebase
Comment 7 Ben Nham 2022-02-05 16:00:44 PST 
Created attachment 451008 [details]
rebase
Comment 8 Brady Eidson 2022-02-07 11:05:03 PST 
Comment on attachment 451008 [details]
rebase

View in context: https://bugs.webkit.org/attachment.cgi?id=451008&action=review

> Source/WebKit/Shared/Cocoa/WebPushMessageCocoa.mm:43
> +    BOOL isNull = pushData == [NSNull null];

You can find example of both in our code base, but it's much more proper to do:
[pushData isEqual:[NSNull null]];
Comment 9 Ben Nham 2022-02-07 11:56:41 PST 
Created attachment 451131 [details]
Patch for landing
Comment 10 EWS 2022-02-07 11:57:45 PST 
ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.
Comment 11 Ben Nham 2022-02-07 12:05:55 PST 
Created attachment 451134 [details]
Patch for landing
Comment 12 EWS 2022-02-07 13:12:03 PST 
Patch 451134 does not build
Comment 13 Ben Nham 2022-02-07 13:19:58 PST 
Created attachment 451144 [details]
Patch for landing
Comment 14 EWS 2022-02-07 14:08:21 PST 
Committed r289239 (246923@main): <https://commits.webkit.org/246923@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451144 [details].
Comment 15 WebKit Commit Bot 2022-02-07 15:10:56 PST 
Re-opened since this is blocked by bug 236264
Comment 16 Ben Nham 2022-02-07 17:22:20 PST 
Created attachment 451182 [details]
Patch for landing
Comment 17 EWS 2022-02-07 18:59:44 PST 
Committed r289353 (246941@main): <https://commits.webkit.org/246941@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451182 [details].
Comment 18 Kate Cheney 2022-02-14 11:25:03 PST 
Comment on attachment 451182 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=451182&action=review

> Source/WebKit/webpushd/WebPushDaemon.mm:621
> +    // FIXME

You may want to include more details in this fixme for future readability.