Bug 235855 - Forward messages from NetworkProcess to webpushd
Summary: Forward messages from NetworkProcess to webpushd
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks: 235857
  Show dependency tree / graph
 
Reported: 2022-01-28 22:47 PST by Ben Nham
Modified: 2022-02-01 16:48 PST (History)
10 users (show)

See Also:

Attachments
Patch (26.22 KB, patch)
2022-01-28 22:48 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Patch (26.79 KB, patch)
2022-01-29 12:44 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Patch (28.78 KB, patch)
2022-01-29 21:55 PST, Ben Nham 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (30.66 KB, patch)
2022-01-29 22:40 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2022-01-28 22:47:27 PST 
Forward messages from NetworkProcess to webpushd
Comment 1 Ben Nham 2022-01-28 22:48:13 PST 
Created attachment 450316 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-01-28 22:49:28 PST 
<rdar://problem/88218250>
Comment 3 Ben Nham 2022-01-29 12:44:51 PST 
Created attachment 450330 [details]
Patch
Comment 4 Ben Nham 2022-01-29 21:55:14 PST 
Created attachment 450350 [details]
Patch
Comment 5 Ben Nham 2022-01-29 22:40:14 PST 
Created attachment 450354 [details]
Patch
Comment 6 Brent Fulgham 2022-02-01 16:33:25 PST 
Comment on attachment 450354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450354&action=review

> Source/WebKit/webpushd/WebPushDaemon.mm:481
> +    UNUSED_PARAM(applicationServerKey);

Should we have any kind of MESSAGE_CHECK macros in here for connection, etc.? Maybe that comes later, once this is fleshed out more?
Comment 7 Ben Nham 2022-02-01 16:35:36 PST 
Comment on attachment 450354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450354&action=review

>> Source/WebKit/webpushd/WebPushDaemon.mm:481
>> +    UNUSED_PARAM(applicationServerKey);
> 
> Should we have any kind of MESSAGE_CHECK macros in here for connection, etc.? Maybe that comes later, once this is fleshed out more?

Yeah, we check whether the parameters are sane in the full implementation (https://bugs.webkit.org/show_bug.cgi?id=235857).
Comment 8 EWS 2022-02-01 16:48:44 PST 
Committed r288929 (246660@main): <https://commits.webkit.org/246660@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450354 [details].