Bug 235821 - Catalyst builds fail for WebCore, WebKi and WebKitLegacy for builds with system content path
Summary: Catalyst builds fail for WebCore, WebKi and WebKitLegacy for builds with syst...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-28 08:07 PST by Michael Saboff
Modified: 2022-01-28 11:43 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.37 KB, patch)
2022-01-28 08:47 PST, Michael Saboff 		saam: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2022-01-28 08:07:22 PST 
JavaScriptCore issus were fixed in <https://bugs.webkit.org/show_bug.cgi?id=235734>.
The WebCore configuration needs to update its rules for JAVASCRIPTCORE_PRIVATE_HEADERS_DIR to include the system content prefix.
The WebKit configuration shouldn't include the system content prefix when computing ALTERNATE_ROOT_PATH (the normal path).  It also needs to create the directory where we create the symlink if it doesn't exist.
WebKitLegacy fails due to the errors in the other projects.
Comment 1 Michael Saboff 2022-01-28 08:07:36 PST 
<rdar://87928380>
Comment 2 Michael Saboff 2022-01-28 08:47:51 PST 
Created attachment 450235 [details]
Patch
Comment 3 Michael Saboff 2022-01-28 11:03:53 PST 
Committed r288749 (246542@trunk): <https://commits.webkit.org/246542@trunk>