Bug 235734 - com.apple.WebKit.WebAuthn.xpc fails to build with system content path
Summary: com.apple.WebKit.WebAuthn.xpc fails to build with system content path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-27 14:25 PST by Michael Saboff
Modified: 2022-01-27 17:37 PST (History)
8 users (show)

See Also:


Attachments
Patch (13.71 KB, patch)
2022-01-27 14:47 PST, Michael Saboff
fpizlo: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2022-01-27 14:25:10 PST
The following build commands failed:
        PhaseScriptExecution Create Symlink to Alt Root Path in target 'WebAuthn' from project 'WebKit'
error: expected a symlink at ..../Library/Frameworks/WebKit.framework/XPCServices/com.apple.WebKit.WebAuthn.xpc

There are also some errors when trying to build for Mac Catalyst where we don't take into account the Catalyst path prefix.
Comment 1 Michael Saboff 2022-01-27 14:26:26 PST
<rdar://88100509>
Comment 2 Michael Saboff 2022-01-27 14:47:54 PST
Created attachment 450183 [details]
Patch
Comment 3 Keith Miller 2022-01-27 14:56:27 PST
Comment on attachment 450183 [details]
Patch

Seems reasonable, r=me
Comment 4 Michael Saboff 2022-01-27 16:24:25 PST
Committed r288710 (?): <https://commits.webkit.org/r288710>