Bug 235712 - [CSS Container Queries] Basic parsing support for query syntax
Summary: [CSS Container Queries] Basic parsing support for query syntax
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks: 229659
  Show dependency treegraph
 
Reported: 2022-01-27 06:52 PST by Antti Koivisto
Modified: 2022-01-27 09:51 PST (History)
12 users (show)

See Also:


Attachments
Patch (17.13 KB, patch)
2022-01-27 07:13 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
Patch for landing (17.75 KB, patch)
2022-01-27 08:35 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Antti Koivisto 2022-01-27 07:13:07 PST
Created attachment 450134 [details]
Patch
Comment 2 Darin Adler 2022-01-27 07:57:57 PST
Comment on attachment 450134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450134&action=review

> Source/WebCore/css/parser/MediaQueryParser.cpp:274
> +            return !equalIgnoringASCIICase(token.value(), "size");

I suspect this can use the slightly more efficient equalLettersIgnoringASCIICase
Comment 3 Antti Koivisto 2022-01-27 08:35:14 PST
Created attachment 450141 [details]
Patch for landing
Comment 4 EWS 2022-01-27 09:50:44 PST
Committed r288675 (246481@main): <https://commits.webkit.org/246481@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450141 [details].
Comment 5 Radar WebKit Bug Importer 2022-01-27 09:51:27 PST
<rdar://problem/88138714>