Bug 235665 - Add copy-to-clipboard button for fuzzy matching meta tag
Summary: Add copy-to-clipboard button for fuzzy matching meta tag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-26 12:36 PST by Jon Lee
Modified: 2022-01-28 10:10 PST (History)
7 users (show)

See Also:


Attachments
Patch (4.62 KB, patch)
2022-01-26 12:41 PST, Jon Lee
no flags Details | Formatted Diff | Diff
Patch (2.43 KB, patch)
2022-01-26 13:55 PST, Jon Lee
no flags Details | Formatted Diff | Diff
Patch (2.60 KB, patch)
2022-01-26 16:32 PST, Jon Lee
no flags Details | Formatted Diff | Diff
Patch (3.28 KB, patch)
2022-01-26 20:26 PST, Jon Lee
no flags Details | Formatted Diff | Diff
Patch (3.28 KB, patch)
2022-01-26 20:41 PST, Jon Lee
no flags Details | Formatted Diff | Diff
Patch (3.28 KB, patch)
2022-01-26 23:28 PST, Jon Lee
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2022-01-26 12:36:14 PST
.
Comment 1 Jon Lee 2022-01-26 12:41:12 PST
Created attachment 450058 [details]
Patch
Comment 2 Simon Fraser (smfr) 2022-01-26 13:13:59 PST
Comment on attachment 450058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450058&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_failures.py:217
> +            return 'maxDifference=0-{}; totalPixels=0-{}'.format(fuzzy_data['max_difference'], fuzzy_data['total_pixels'])

I worry that this is going to encourage 0-N ranges for all time, in all contexts. We really only want it for tests affected by accelerated drawing.
Comment 3 Jon Lee 2022-01-26 13:55:44 PST
Created attachment 450066 [details]
Patch
Comment 4 Jon Lee 2022-01-26 16:32:05 PST
Created attachment 450082 [details]
Patch
Comment 5 Simon Fraser (smfr) 2022-01-26 20:14:36 PST
Need new results for the layout test that is also the diff page.
Comment 6 Jon Lee 2022-01-26 20:26:39 PST
Created attachment 450098 [details]
Patch
Comment 7 Jon Lee 2022-01-26 20:41:24 PST
Created attachment 450099 [details]
Patch
Comment 8 Jon Lee 2022-01-26 23:28:51 PST
Created attachment 450105 [details]
Patch
Comment 9 Darin Adler 2022-01-27 16:39:07 PST
Comment on attachment 450105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450105&action=review

rs=me

> LayoutTests/ChangeLog:11
> +        * fast/harness/image-diff-template-expected.txt:

Maybe at some point we can move this harness into a "resources" directory so we don’t have to also run it as a test?
Comment 10 Simon Fraser (smfr) 2022-01-27 16:41:20 PST
I think running it as a test is a "feature".
Comment 11 Jon Lee 2022-01-28 10:09:36 PST
Committed r288745 (246538@trunk): <https://commits.webkit.org/246538@trunk>
Comment 12 Radar WebKit Bug Importer 2022-01-28 10:10:17 PST
<rdar://problem/88191824>