Bug 235541 – Web Inspector: Console: move Preserve Log checkbox navigation item to a gear-with-contextmenu to save space (and match the Network Tab)

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

see bug 235538

[Devin Rousso]

Created attachment 449955 [details]
[fast-cq] Patch

[Devin Rousso]

Created attachment 449956 [details]
[Image] after Patch is applied

[Patrick Angle]

Comment on attachment 449955 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449955&action=review

> Source/WebInspectorUI/ChangeLog:33
> +        Somehow this got overlooked when the constructor of `WI.ContentBrowser` was changed :(

Oops. Pretty sure that is my fault 🤦🏻‍♂️

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:103
> +        this._scopeBar = new WI.ScopeBar("log-scope-bar", scopeBarItems, scopeBarItems[0], shouldGroupNonExclusiveItems);

I'm not convinced turning the scope filter items into a dropdown is a good choice here. It is easily possible for multiple items to become selected currently. In fact, if I right click and inspect this page and go to the console tab, I see that by default both "Evaluations" and "Errors" are selected by default. At least for me, seeing "Errors" and "Warnings" at the same time is also common use case.

[Devin Rousso]

Comment on attachment 449955 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449955&action=review

>> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:103
>> +        this._scopeBar = new WI.ScopeBar("log-scope-bar", scopeBarItems, scopeBarItems[0], shouldGroupNonExclusiveItems);
> 
> I'm not convinced turning the scope filter items into a dropdown is a good choice here. It is easily possible for multiple items to become selected currently. In fact, if I right click and inspect this page and go to the console tab, I see that by default both "Evaluations" and "Errors" are selected by default. At least for me, seeing "Errors" and "Warnings" at the same time is also common use case.

Oh good point.  I totally forgot about this feature 😅

OK I'll pull this part out, but leave the rest of the changes (e.g. move to the left, add `Filter.svg`, etc.).

I may also investigate making `WI.MultipleScopeBarItem` actually support multiple items being selected at once (tho that might result in the displayed text just being something like "(multiple)").

[Devin Rousso]

Created attachment 450174 [details]
[fast-cq] Patch

[Patrick Angle]

Comment on attachment 450174 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450174&action=review

r=me

> Source/WebInspectorUI/ChangeLog:8
> +        Also collapse the type (and source) scope bar into a single button for more space, and align

Nit: Just the source scope bar now.

[Devin Rousso]

Created attachment 450176 [details]
[fast-cq] Patch

[EWS]

Committed r288702 (246500@main): <https://commits.webkit.org/246500@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450176 [details].

[Radar WebKit Bug Importer]

<rdar://problem/88159552>