Bug 235538 – Web Inspector: Network: move filtering checkboxes into a single gear-with-contextmenu to save space

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

.

[Devin Rousso]

Created attachment 449852 [details]
[fast-cq] Patch

[Patrick Angle]

Comment on attachment 449852 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449852&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:2281
> +        contextMenu.appendCheckboxItem(WI.UIString("Preserve Log"), () => {

An aside, but could certainly be dealt with in this same bug: `Preserve Log` to me doesn't clearly communicate what this setting does. When I think "log", I think about the Console Tab and `console.log` et al.. Something like "Clear requests on navigation" or "Clear request history on navigation" (subject to further bike shedding) would better communicate the option IMO now that these are in a dropdown menu and we have a bit more space.

[Devin Rousso]

Comment on attachment 449852 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449852&action=review

>> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:2281
>> +        contextMenu.appendCheckboxItem(WI.UIString("Preserve Log"), () => {
> 
> An aside, but could certainly be dealt with in this same bug: `Preserve Log` to me doesn't clearly communicate what this setting does. When I think "log", I think about the Console Tab and `console.log` et al.. Something like "Clear requests on navigation" or "Clear request history on navigation" (subject to further bike shedding) would better communicate the option IMO now that these are in a dropdown menu and we have a bit more space.

Yeah that's a good point.  We should change this to something clearer now that it's in a contextmenu (which gives us more space).

Also, we should probably do something similar in the Console since there's a "Preserve Log" there too <https://webkit.org/b/235541>

[Devin Rousso]

Created attachment 449857 [details]
[Image] after Patch is applied

[EWS]

Committed r288470 (246355@main): <https://commits.webkit.org/246355@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449852 [details].

[Radar WebKit Bug Importer]

<rdar://problem/87990907>