Bug 235531 - Sort IDL extended attributes alphabetically
Summary: Sort IDL extended attributes alphabetically
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebXR (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-24 11:27 PST by Sam Sneddon [:gsnedders]
Modified: 2022-03-27 19:36 PDT (History)
8 users (show)

See Also:

Attachments
Everywhere where EnabledBySetting comes before Conditional (5.86 KB, text/plain)
2022-01-24 11:27 PST, Sam Sneddon [:gsnedders] 		no flags Details
Patch (29.27 KB, patch)
2022-03-27 01:07 PDT, Daniel Adams 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2022-01-24 11:27:20 PST 
Created attachment 449835 [details]
Everywhere where EnabledBySetting comes before Conditional

Per Darin in comment #2 on Bug 235527:

> Comment on attachment 449829 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=449829&action=review
> 
> > Source/WebCore/Modules/webxr/XRFrameRequestCallback.idl:31
> > +    EnabledBySetting=WebXREnabled,
> >      Conditional=WEBXR
> 
> Normally we like to keep these alphabetical.

The existing IDL should be fixed to adhere to this; this is almost entirely in WebXR & related testing IDL.
Comment 1 Radar WebKit Bug Importer 2022-01-31 11:28:19 PST 
<rdar://problem/88284366>
Comment 2 Daniel Adams 2022-03-27 01:07:06 PDT 
Created attachment 455864 [details]
Patch
Comment 3 Sam Weinig 2022-03-27 08:36:28 PDT 
Comment on attachment 455864 [details]
Patch

We should probably enforce this in the IDL parser for good measure at some point.
Comment 4 EWS 2022-03-27 19:36:24 PDT 
Committed r291954 (248921@main): <https://commits.webkit.org/248921@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455864 [details].