Bug 235527 - Missing EnabledBySetting=WebXREnabled where Conditional=WEBXR exists
Summary: Missing EnabledBySetting=WebXREnabled where Conditional=WEBXR exists
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebXR (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-24 10:35 PST by Sam Sneddon [:gsnedders]
Modified: 2022-01-25 08:49 PST (History)
11 users (show)

See Also:

Attachments
Patch (2.84 KB, patch)
2022-01-24 10:45 PST, Sam Sneddon [:gsnedders] 		no flags Details | Formatted Diff | Diff
Patch (2.86 KB, patch)
2022-01-24 11:20 PST, Sam Sneddon [:gsnedders] 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2022-01-24 10:35:14 PST 
There's a few places we're missing this, patch forthcoming.

<rdar://87976757>
Comment 1 Sam Sneddon [:gsnedders] 2022-01-24 10:45:27 PST 
Created attachment 449829 [details]
Patch
Comment 2 Darin Adler 2022-01-24 11:07:26 PST 
Comment on attachment 449829 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449829&action=review

> Source/WebCore/Modules/webxr/XRFrameRequestCallback.idl:31
> +    EnabledBySetting=WebXREnabled,
>      Conditional=WEBXR

Normally we like to keep these alphabetical.
Comment 3 Sam Sneddon [:gsnedders] 2022-01-24 11:20:34 PST 
Created attachment 449832 [details]
Patch
Comment 4 EWS 2022-01-25 08:49:06 PST 
Committed r288553 (246385@main): <https://commits.webkit.org/246385@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449832 [details].