Bug 235530 - [Forms] make sure :active is removed on keyup for radios
Summary: [Forms] make sure :active is removed on keyup for radios
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zsun
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-24 11:20 PST by zsun
Modified: 2022-05-19 04:37 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2022-01-24 11:24 PST, zsun 		no flags Details | Formatted Diff | Diff
Patch (1.89 KB, patch)
2022-02-03 01:26 PST, zsun 		no flags Details | Formatted Diff | Diff
Patch (3.63 KB, patch)
2022-05-17 01:49 PDT, zsun 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.73 KB, patch)
2022-05-19 02:12 PDT, zsun 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zsun 2022-01-24 11:20:05 PST 
WPT test-

imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/radio-double-activate-pseudo.html
Comment 1 zsun 2022-01-24 11:24:45 PST 
Created attachment 449834 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-01-31 11:21:46 PST 
<rdar://problem/88283930>
Comment 3 zsun 2022-02-03 01:26:40 PST 
Created attachment 450745 [details]
Patch
Comment 4 Chris Dumez 2022-03-28 11:39:14 PDT 
Comment on attachment 450745 [details]
Patch

Seems we need a layout test.
Comment 5 Tim Nguyen (:ntim) 2022-05-16 15:37:22 PDT 
Why does html/semantics/forms/the-input-element/radio-double-activate-pseudo.html not start passing?
Comment 6 zsun 2022-05-17 01:49:44 PDT 
Created attachment 459490 [details]
Patch
Comment 7 zsun 2022-05-17 01:53:32 PDT 
(In reply to Tim Nguyen (:ntim) from comment #5)
> Why does
> html/semantics/forms/the-input-element/radio-double-activate-pseudo.html not
> start passing?

bug 237589 corrected the test expectation file for test html/semantics/forms/the-input-element/radio-double-activate-pseudo.html.

Patch has been updated and the test should pass now.
Comment 8 Chris Dumez 2022-05-17 07:56:24 PDT 
Comment on attachment 459490 [details]
Patch

r=me
Comment 9 Tim Nguyen (:ntim) 2022-05-17 10:39:09 PDT 
For this bug and bug 235522, note that changelogs are now deprecated (see the webkit-dev message), you'll need to use the Github workflow with a complete commit message.
Comment 10 zsun 2022-05-19 02:12:51 PDT 
Created attachment 459573 [details]
Patch
Comment 11 EWS 2022-05-19 04:37:47 PDT 
Committed r294475 (250734@main): <https://commits.webkit.org/250734@main>

Reviewed commits have been landed. Closing PR #773 and removing active labels.