Bug 235522 - [Forms] Fix input type email visible value update
Summary: [Forms] Fix input type email visible value update
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zsun
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-24 08:48 PST by zsun
Modified: 2022-05-19 04:42 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2022-01-24 08:53 PST, zsun 		no flags Details | Formatted Diff | Diff
Patch (3.62 KB, patch)
2022-05-17 02:36 PDT, zsun 		no flags Details | Formatted Diff | Diff
Patch (2.74 KB, patch)
2022-05-19 01:56 PDT, zsun 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zsun 2022-01-24 08:48:49 PST 
Affect test

imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/email-set-value.html
Comment 1 zsun 2022-01-24 08:53:07 PST 
Created attachment 449823 [details]
Patch
Comment 2 zsun 2022-01-24 08:53:56 PST 
Not ready for review yet.
Comment 3 Radar WebKit Bug Importer 2022-01-31 09:38:43 PST 
<rdar://problem/88276285>
Comment 4 zsun 2022-05-17 02:36:24 PDT 
Created attachment 459493 [details]
Patch
Comment 5 Chris Dumez 2022-05-17 07:57:35 PDT 
Comment on attachment 459493 [details]
Patch

r=me
Comment 6 Tim Nguyen (:ntim) 2022-05-18 01:16:43 PDT 
Comment on attachment 459493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459493&action=review

> Source/WebCore/html/TextFieldInputType.cpp:146
> +    bool needTextUpdate = valueChanged || (eventBehavior == TextFieldEventBehavior::DispatchNoEvent && sanitizedValue != element()->innerTextValue());
> +    if (needTextUpdate)

grammar nit: needsTextUpdate
Comment 7 zsun 2022-05-19 01:56:38 PDT 
Created attachment 459572 [details]
Patch
Comment 8 EWS 2022-05-19 04:42:49 PDT 
Committed r294476 (250735@main): <https://commits.webkit.org/250735@main>

Reviewed commits have been landed. Closing PR #774 and removing active labels.