Bug 235516 - EWS results (GitHub checks) are not displayed while logged out from GitHub
Summary: EWS results (GitHub checks) are not displayed while logged out from GitHub
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-24 07:41 PST by Aakash Jain
Modified: 2023-08-11 14:02 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2022-01-24 07:41:11 PST 
Currently, EWS results (default GitHub checks UI) are not displayed while logged out from GitHub. For e.g.: https://github.com/WebKit/WebKit/pull/89 (currently un-merged) shows the checks information while logged into GitHub, but doesn't show the information while logged out.

Not sure if this is critical, since reviewers would need to login to review the PR or leave any comments anyways. But it would probably be nice if the EWS results are displayed without logging in as well, e.g.: someone checking the PR on mobile to have a quick look if the PR is good, or bot-watchers looking at failing builds.

If someone have strong opinion on this, it would be good to know that.
Comment 1 Jonathan Bedard 2022-01-24 09:16:12 PST 
Feels like the solution to this is what we're pursing: have EWS have a comment which it updates.
Comment 2 Radar WebKit Bug Importer 2022-01-31 07:42:18 PST 
<rdar://problem/88269684>
Comment 3 Aakash Jain 2023-08-11 14:02:15 PDT 
We now have EWS status-bubbles which don't have this problem.