Bug 235306 - [github] Files changed and commits tabs become empty after merging the Pull Request
Summary: [github] Files changed and commits tabs become empty after merging the Pull R...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-17 17:18 PST by Aakash Jain
Modified: 2022-01-24 07:41 PST (History)
1 user (show)

See Also:

Attachments
GitHub Merged PR Screenshot (707.48 KB, image/png)
2022-01-17 17:18 PST, Aakash Jain 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2022-01-17 17:18:30 PST 
Created attachment 449358 [details]
GitHub Merged PR Screenshot

"Files changed" and "commits" tabs become empty after merging the Pull Request (screenshot attached). This makes it harder for anyone to re-review any pull-request (after it is merged), or to leave a comment on specific portion of the PR after it's merged. For example if I found an issue in the PR which was already merged, I would like to look at the PR code again and leave a comment at a specific line of code.

I believe this is not the default github behavior, and is due to the way we (git-webkit) are handling the PRs.
Comment 1 Jonathan Bedard 2022-01-18 10:07:33 PST 
We won't be able to fix this.

The reason this is happening is because we're aren't really merging the pull-request, we're landing the pull-request via SVN, then importing the SVN commit into git, updating the branch ref of the PR branch to match the landed commit and then closing the pull-request. Frankly, we're fortunate that GitHub actually marks such changes as "merged", BitBucket, for example, will not.