Bug 235513 - Incorrect pull-request url printed by git-webkit
Summary: Incorrect pull-request url printed by git-webkit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-24 06:40 PST by Aakash Jain
Modified: 2022-03-26 07:28 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch (2.54 KB, patch)
2022-01-24 11:47 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2022-01-24 06:40:31 PST 
After the fix in https://github.com/WebKit/WebKit/pull/80, git-webkit pr now prints the pr url, which is great. However, the url has a typo making it incorrect.

e.g.: https://github.com/WebKit/WebKit/pulls/89 instead of https://github.com/WebKit/WebKit/pull/89  (pulls instead of pull). We should fix this.
Comment 1 Aakash Jain 2022-01-24 11:47:44 PST 
Created attachment 449838 [details]
Proposed patch
Comment 2 Aakash Jain 2022-01-24 12:10:53 PST 
Pull Request: https://github.com/WebKit/WebKit/pull/91
Comment 3 Aakash Jain 2022-01-25 05:44:43 PST 
Landed https://commits.webkit.org/246353@main (d6f2ef7)!
Comment 4 Radar WebKit Bug Importer 2022-01-25 05:45:23 PST 
<rdar://problem/88019800>