Bug 235490 - [Flatpak SDK] Extension points for the Flatpak Sparkle-CDM extension
Summary: [Flatpak SDK] Extension points for the Flatpak Sparkle-CDM extension
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks: 235489
  Show dependency treegraph
 
Reported: 2022-01-23 06:55 PST by Philippe Normand
Modified: 2022-02-04 08:52 PST (History)
2 users (show)

See Also:


Attachments
[fast-cq] Patch (2.13 KB, patch)
2022-01-23 08:54 PST, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2022-01-23 06:55:54 PST
bst bits allowing our Sdk and Platform to have the extension mounted in the runtime sandbox.
Comment 1 Philippe Normand 2022-01-23 08:54:50 PST
Created attachment 449751 [details]
[fast-cq] Patch
Comment 2 Adrian Perez 2022-02-04 07:57:08 PST
Comment on attachment 449751 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449751&action=review

> Tools/buildstream/elements/flatpak/platform.bst:84
> +      no-autodownload: 'true'

What's the reason to quote the booleans? They could as well be specified
directly as they are valid YAML values:

  autodelete: False
  no-autodownload: True

I know that there are many other instances around which are strings, but
the man page for fltpak-metadata clearly states that these fields are
indeed booleans (not strings). Probably this has been working fine because
when saving the data back when building the image the writer that is
serializing the values by chance chooses to write the strings unquoted
(which is allowed in YAML) and the parser from the Flatpak tooling is
magnanimous enough to accept the lowercase unquoted “true“ and “false“
strings as booleans.

Or am I overthinking things here? Anyway, we know the current approach
works and I am mostly wondering what's going on in reality.
Comment 3 Philippe Normand 2022-02-04 08:48:23 PST
I honestly have no clue what to answer, excepted that iirc I took inspiration in the FDO SDK, maybe the syntax improved since then and this has bitrotten. I can follow-up about this in a separate patch :)
Comment 4 EWS 2022-02-04 08:51:29 PST
Committed r289118 (246815@main): <https://commits.webkit.org/246815@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449751 [details].
Comment 5 Radar WebKit Bug Importer 2022-02-04 08:52:18 PST
<rdar://problem/88491360>