Bug 235398 – Update LayoutTests/resources/testharness.js to 2021-6-24 version

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Kimmo Kinnunen]

Update LayoutTests/resources/testharness.js to 2021-6-24 version
to match LayoutTests/imported/w3c/web-platform-tests/resources/testharness.js

The harness has useful step_wait functions now

[Kimmo Kinnunen]

Created attachment 449563 [details]
Patch

[youenn fablet]

Comment on attachment 449563 [details]
Patch

r=me once bots are happy.

[Sam Sneddon [:gsnedders]]

Comment on attachment 449563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449563&action=review

What's the reason for going for the 2021-06-24 version rather than something more recent?

> LayoutTests/resources/testharnessreport.js:11
> - * Typically such integration will attach callbacks when each test is
> - * has run, using add_result_callback(callback(test)), or when the whole test file has
> - * completed, using add_completion_callback(callback(tests, harness_status)).
> + * Typically test system integration will attach callbacks when each test has
> + * run, using add_result_callback(callback(test)), or when the whole test file
> + * has completed, using
> + * add_completion_callback(callback(tests, harness_status)).

Don't replace this file; keep our own version.

[Kimmo Kinnunen]

Created attachment 449648 [details]
Patch

[Kimmo Kinnunen]

Created attachment 450121 [details]
Patch for landing

[Radar WebKit Bug Importer]

<rdar://problem/88126222>

[Kimmo Kinnunen]

Created attachment 450207 [details]
Patch for landing

[Kimmo Kinnunen]

Created attachment 450216 [details]
Patch for landing

[Kimmo Kinnunen]

Created attachment 450219 [details]
Patch for landing

[youenn fablet]

Comment on attachment 450219 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=450219&action=review

> LayoutTests/http/tests/paymentrequest/payment-is-showing.https.html:-292
> -      );

Why are we removing this one?

[EWS]

Committed r288806 (246582@main): <https://commits.webkit.org/246582@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450219 [details].

[Kimmo Kinnunen]

> What's the reason for going for the 2021-06-24 version rather than something more recent?

Just to stay consistent with LayoutTests/imported/w3c/web-platform-tests/resources/testharness.js