Bug 235398 - Update LayoutTests/resources/testharness.js to 2021-6-24 version
Summary: Update LayoutTests/resources/testharness.js to 2021-6-24 version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on: 235560
Blocks:
  Show dependency tree / graph
 
Reported: 2022-01-20 04:15 PST by Kimmo Kinnunen
Modified: 2022-02-01 02:33 PST (History)
15 users (show)

See Also:

Attachments
Patch (96.31 KB, patch)
2022-01-20 04:20 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (452.06 KB, patch)
2022-01-21 03:21 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch for landing (456.99 KB, patch)
2022-01-27 03:12 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch for landing (626.92 KB, patch)
2022-01-27 23:34 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch for landing (640.95 KB, patch)
2022-01-28 02:28 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch for landing (641.29 KB, patch)
2022-01-28 03:21 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-01-20 04:15:39 PST 
Update LayoutTests/resources/testharness.js to 2021-6-24 version
to match LayoutTests/imported/w3c/web-platform-tests/resources/testharness.js

The harness has useful step_wait functions now
Comment 1 Kimmo Kinnunen 2022-01-20 04:20:03 PST 
Created attachment 449563 [details]
Patch
Comment 2 youenn fablet 2022-01-20 04:25:10 PST 
Comment on attachment 449563 [details]
Patch

r=me once bots are happy.
Comment 3 Sam Sneddon [:gsnedders] 2022-01-20 06:24:16 PST 
Comment on attachment 449563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449563&action=review

What's the reason for going for the 2021-06-24 version rather than something more recent?

> LayoutTests/resources/testharnessreport.js:11
> - * Typically such integration will attach callbacks when each test is
> - * has run, using add_result_callback(callback(test)), or when the whole test file has
> - * completed, using add_completion_callback(callback(tests, harness_status)).
> + * Typically test system integration will attach callbacks when each test has
> + * run, using add_result_callback(callback(test)), or when the whole test file
> + * has completed, using
> + * add_completion_callback(callback(tests, harness_status)).

Don't replace this file; keep our own version.
Comment 4 Kimmo Kinnunen 2022-01-21 03:21:57 PST 
Created attachment 449648 [details]
Patch
Comment 5 Kimmo Kinnunen 2022-01-27 03:12:16 PST 
Created attachment 450121 [details]
Patch for landing
Comment 6 Radar WebKit Bug Importer 2022-01-27 04:16:18 PST 
<rdar://problem/88126222>
Comment 7 Kimmo Kinnunen 2022-01-27 23:34:52 PST 
Created attachment 450207 [details]
Patch for landing
Comment 8 Kimmo Kinnunen 2022-01-28 02:28:00 PST 
Created attachment 450216 [details]
Patch for landing
Comment 9 Kimmo Kinnunen 2022-01-28 03:21:35 PST 
Created attachment 450219 [details]
Patch for landing
Comment 10 youenn fablet 2022-01-28 04:37:12 PST 
Comment on attachment 450219 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=450219&action=review

> LayoutTests/http/tests/paymentrequest/payment-is-showing.https.html:-292
> -      );

Why are we removing this one?
Comment 11 EWS 2022-01-30 21:48:44 PST 
Committed r288806 (246582@main): <https://commits.webkit.org/246582@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450219 [details].
Comment 12 Kimmo Kinnunen 2022-02-01 02:09:34 PST 
> What's the reason for going for the 2021-06-24 version rather than something more recent?

Just to stay consistent with LayoutTests/imported/w3c/web-platform-tests/resources/testharness.js