Bug 235560 - Streams tests try to call ReadableStream.prototype.pipeThrough.call generically
Summary: Streams tests try to call ReadableStream.prototype.pipeThrough.call generically
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 235398
  Show dependency tree / graph
 
Reported: 2022-01-24 23:57 PST by Kimmo Kinnunen
Modified: 2022-01-26 01:49 PST (History)
5 users (show)

See Also:

Attachments
Patch (15.09 KB, patch)
2022-01-25 00:00 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-01-24 23:57:06 PST 
Streams tests try to call ReadableStream.prototype.pipeThrough.call generically

ReadableStream methods are nowadays defined to accept only ReadableStream instances.
Tests sometimes assert that an exception is thrown. However, the exception being actually thrown is different.
Future testharness.js will check the exception and the test will fail.
Comment 1 Kimmo Kinnunen 2022-01-25 00:00:06 PST 
Created attachment 449901 [details]
Patch
Comment 2 youenn fablet 2022-01-25 00:45:12 PST 
Comment on attachment 449901 [details]
Patch

r=me, all these tests are older versions of tests that we run in LayoutTests/imported/w3c/web-platform-tests/streams folder/subfolders
Comment 3 EWS 2022-01-26 01:48:19 PST 
Committed r288611 (246430@main): <https://commits.webkit.org/246430@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449901 [details].
Comment 4 Radar WebKit Bug Importer 2022-01-26 01:49:17 PST 
<rdar://problem/88065943>