Bug 235319 – CSP: Fix returned WebAssembly error type when blocked

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Patrick Griffis]

CSP: Fix returned WebAssembly error type when blocked

[Patrick Griffis]

Created attachment 449392 [details]
Patch

[Patrick Griffis]

Created attachment 449393 [details]
Patch

[Patrick Griffis]

Created attachment 449402 [details]
Patch

[Kate Cheney]

Comment on attachment 449402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449402&action=review

Should imported/w3c/web-platform-tests/content-security-policy/wasm-unsafe-eval/script-src-spv-asynch.any.html and imported/w3c/web-platform-tests/content-security-policy/wasm-unsafe-eval/script-src-spv-asynch.any.serviceworker.html also be skipped?

> LayoutTests/ChangeLog:8
> +        Ignore CSP test that timesout.

nit: should be a space between times and out.

[Darin Adler]

Comment on attachment 449402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449402&action=review

Looks like a good change, but a lot of tests are failing on mac-wk1, please don’t land without investigating that.

Also, this should be two patches, not as single patch.

> Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp:176
> +        return exception(createJSWebAssemblyCompileError(globalObject, vm, globalObject->webAssemblyDisabledErrorMessage()));

This should be two separate patches.

First, import the tests.

Then, add the fix and update the test results to show the newly-passing tests.

Combining the two isn’t great.

[Patrick Griffis]

Created attachment 449419 [details]
Patch

[Patrick Griffis]

(In reply to Darin Adler from comment #5)
> Comment on attachment 449402 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=449402&action=review
> 
> Looks like a good change, but a lot of tests are failing on mac-wk1, please
> don’t land without investigating that.

Just no ServiceWorker there, skipped now.


> This should be two separate patches.
> 
> First, import the tests.
> 
> Then, add the fix and update the test results to show the newly-passing
> tests.
> 
> Combining the two isn’t great.


OK.

[Patrick Griffis]

Created attachment 449421 [details]
WPT: Import WebAssembly CSP tests

[Patrick Griffis]

Created attachment 449422 [details]
CSP: Fix returned WebAssembly error type when blocked

[Patrick Griffis]

(In reply to Kate Cheney from comment #4)
> Comment on attachment 449402 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=449402&action=review
> 
> Should
> imported/w3c/web-platform-tests/content-security-policy/wasm-unsafe-eval/
> script-src-spv-asynch.any.html and
> imported/w3c/web-platform-tests/content-security-policy/wasm-unsafe-eval/
> script-src-spv-asynch.any.serviceworker.html also be skipped?
> 

Indeed, added.

[Radar WebKit Bug Importer]

<rdar://problem/88024254>

[EWS]

Committed r288959 (246688@main): <https://commits.webkit.org/246688@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449421 [details].

[Patrick Griffis]

Reopening as there was a second patch.

[EWS]

Committed r288992 (246711@main): <https://commits.webkit.org/246711@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449422 [details].