WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
235266
[LFC][IFC] Enable content with complex font codepath for IFC
https://bugs.webkit.org/show_bug.cgi?id=235266
Summary
[LFC][IFC] Enable content with complex font codepath for IFC
alan baradlay
Reported
2022-01-15 06:24:47 PST
ssia
Attachments
Patch
(83.03 KB, patch)
2022-01-15 06:26 PST
,
alan baradlay
no flags
Details
Formatted Diff
Diff
Patch
(123.61 KB, patch)
2022-01-15 09:43 PST
,
alan baradlay
no flags
Details
Formatted Diff
Diff
Patch
(123.10 KB, patch)
2022-01-15 10:45 PST
,
alan baradlay
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
alan baradlay
Comment 1
2022-01-15 06:26:16 PST
Created
attachment 449252
[details]
Patch
Antti Koivisto
Comment 2
2022-01-15 07:14:26 PST
Comment on
attachment 449252
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=449252&action=review
> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:-406 > - SET_REASON_AND_RETURN_IF_NEEDED(FlowHasComplexFontCodePath, reasons, includeReasons);
Not removing FlowHasComplexFontCodePath?
alan baradlay
Comment 3
2022-01-15 09:43:17 PST
Created
attachment 449254
[details]
Patch
alan baradlay
Comment 4
2022-01-15 09:43:38 PST
(In reply to Antti Koivisto from
comment #2
)
> Comment on
attachment 449252
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=449252&action=review
> > > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:-406 > > - SET_REASON_AND_RETURN_IF_NEEDED(FlowHasComplexFontCodePath, reasons, includeReasons); > > Not removing FlowHasComplexFontCodePath?
good point!
alan baradlay
Comment 5
2022-01-15 10:45:13 PST
Created
attachment 449258
[details]
Patch
EWS
Comment 6
2022-01-15 20:44:23 PST
Committed
r288070
(
246090@main
): <
https://commits.webkit.org/246090@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 449258
[details]
.
Radar WebKit Bug Importer
Comment 7
2022-01-15 20:45:17 PST
<
rdar://problem/87645178
>
Wenson Hsieh
Comment 8
2022-01-16 17:04:51 PST
It seems like several `TestWebKitAPI.WKInspectorExtension*` API tests started failing or timing out after this change:
https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.WKInspectorExtension.CanEvaluateScriptInExtensionTab&test=TestWebKitAPI.WKInspectorExtension.EvaluateScriptInExtensionTabCanReturnPromises&test=TestWebKitAPI.WKInspectorExtension.EvaluateScriptOnPage&test=TestWebKitAPI.WKInspectorExtension.ExtensionTabIsPersistent&test=TestWebKitAPI.WKInspectorExtensionDelegate.ExtensionTabNavigatedCallbacks&test=TestWebKitAPI.WKInspectorExtensionDelegate.InspectedPageNavigatedCallbacks&test=TestWebKitAPI.WKInspectorExtensionDelegate.ShowAndHideTabCallbacks&test=TestWebKitAPI.WKInspectorExtensionHost.RegisterExtension&test=TestWebKitAPI.WKInspectorExtensionHost.UnregisterExtension
alan baradlay
Comment 9
2022-01-16 20:38:07 PST
(In reply to Wenson Hsieh from
comment #8
)
> It seems like several `TestWebKitAPI.WKInspectorExtension*` API tests > started failing or timing out after this change: > >
https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api
- > tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api- > tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI. > WKInspectorExtension.CanEvaluateScriptInExtensionTab&test=TestWebKitAPI. > WKInspectorExtension. > EvaluateScriptInExtensionTabCanReturnPromises&test=TestWebKitAPI. > WKInspectorExtension.EvaluateScriptOnPage&test=TestWebKitAPI. > WKInspectorExtension.ExtensionTabIsPersistent&test=TestWebKitAPI. > WKInspectorExtensionDelegate. > ExtensionTabNavigatedCallbacks&test=TestWebKitAPI. > WKInspectorExtensionDelegate. > InspectedPageNavigatedCallbacks&test=TestWebKitAPI. > WKInspectorExtensionDelegate.ShowAndHideTabCallbacks&test=TestWebKitAPI. > WKInspectorExtensionHost.RegisterExtension&test=TestWebKitAPI. > WKInspectorExtensionHost.UnregisterExtension
Odd. Will take a look.
alan baradlay
Comment 10
2022-01-16 20:48:14 PST
The TestWebKitAPI content triggers ASSERT(partialRun->length); in InlineContentBreaker::tryBreakingPreviousNonOverflowingRuns Interesting. Fixing it...
alan baradlay
Comment 11
2022-01-16 20:52:23 PST
(In reply to zalan from
comment #10
)
> The TestWebKitAPI content triggers ASSERT(partialRun->length); in > InlineContentBreaker::tryBreakingPreviousNonOverflowingRuns > Interesting. Fixing it...
Nope, the inspector content triggers the assert and not the test content.
alan baradlay
Comment 12
2022-01-16 22:01:46 PST
bug 235286
alan baradlay
Comment 13
2022-01-17 09:28:17 PST
(In reply to Wenson Hsieh from
comment #8
)
> It seems like several `TestWebKitAPI.WKInspectorExtension*` API tests > started failing or timing out after this change: > >
https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api
- > tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api- > tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI. > WKInspectorExtension.CanEvaluateScriptInExtensionTab&test=TestWebKitAPI. > WKInspectorExtension. > EvaluateScriptInExtensionTabCanReturnPromises&test=TestWebKitAPI. > WKInspectorExtension.EvaluateScriptOnPage&test=TestWebKitAPI. > WKInspectorExtension.ExtensionTabIsPersistent&test=TestWebKitAPI. > WKInspectorExtensionDelegate. > ExtensionTabNavigatedCallbacks&test=TestWebKitAPI. > WKInspectorExtensionDelegate. > InspectedPageNavigatedCallbacks&test=TestWebKitAPI. > WKInspectorExtensionDelegate.ShowAndHideTabCallbacks&test=TestWebKitAPI. > WKInspectorExtensionHost.RegisterExtension&test=TestWebKitAPI. > WKInspectorExtensionHost.UnregisterExtension
https://trac.webkit.org/changeset/288095/webkit
should take care of these failures. Thanks!
Arcady Goldmints-Orlov
Comment 14
2022-01-17 09:33:30 PST
***
Bug 218510
has been marked as a duplicate of this bug. ***
Arcady Goldmints-Orlov
Comment 15
2022-01-17 09:38:09 PST
***
Bug 218930
has been marked as a duplicate of this bug. ***
Arcady Goldmints-Orlov
Comment 16
2022-01-17 09:38:51 PST
***
Bug 226474
has been marked as a duplicate of this bug. ***
Arcady Goldmints-Orlov
Comment 17
2022-01-17 09:40:53 PST
***
Bug 217421
has been marked as a duplicate of this bug. ***
Arcady Goldmints-Orlov
Comment 18
2022-01-17 09:42:54 PST
***
Bug 217946
has been marked as a duplicate of this bug. ***
Arcady Goldmints-Orlov
Comment 19
2022-01-17 09:43:51 PST
***
Bug 197277
has been marked as a duplicate of this bug. ***
Arcady Goldmints-Orlov
Comment 20
2022-01-17 09:44:47 PST
***
Bug 197409
has been marked as a duplicate of this bug. ***
Arcady Goldmints-Orlov
Comment 21
2022-01-17 09:45:20 PST
***
Bug 197411
has been marked as a duplicate of this bug. ***
Arcady Goldmints-Orlov
Comment 22
2022-01-17 09:51:11 PST
***
Bug 224590
has been marked as a duplicate of this bug. ***
Arcady Goldmints-Orlov
Comment 23
2022-01-17 09:52:09 PST
***
Bug 193491
has been marked as a duplicate of this bug. ***
Arcady Goldmints-Orlov
Comment 24
2022-01-17 09:52:40 PST
***
Bug 230414
has been marked as a duplicate of this bug. ***
Arcady Goldmints-Orlov
Comment 25
2022-01-17 09:53:25 PST
***
Bug 232910
has been marked as a duplicate of this bug. ***
alan baradlay
Comment 26
2022-06-09 20:25:55 PDT
***
Bug 220942
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug