ssia
Created attachment 449252 [details] Patch
Comment on attachment 449252 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449252&action=review > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:-406 > - SET_REASON_AND_RETURN_IF_NEEDED(FlowHasComplexFontCodePath, reasons, includeReasons); Not removing FlowHasComplexFontCodePath?
Created attachment 449254 [details] Patch
(In reply to Antti Koivisto from comment #2) > Comment on attachment 449252 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=449252&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:-406 > > - SET_REASON_AND_RETURN_IF_NEEDED(FlowHasComplexFontCodePath, reasons, includeReasons); > > Not removing FlowHasComplexFontCodePath? good point!
Created attachment 449258 [details] Patch
Committed r288070 (246090@main): <https://commits.webkit.org/246090@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449258 [details].
<rdar://problem/87645178>
It seems like several `TestWebKitAPI.WKInspectorExtension*` API tests started failing or timing out after this change: https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.WKInspectorExtension.CanEvaluateScriptInExtensionTab&test=TestWebKitAPI.WKInspectorExtension.EvaluateScriptInExtensionTabCanReturnPromises&test=TestWebKitAPI.WKInspectorExtension.EvaluateScriptOnPage&test=TestWebKitAPI.WKInspectorExtension.ExtensionTabIsPersistent&test=TestWebKitAPI.WKInspectorExtensionDelegate.ExtensionTabNavigatedCallbacks&test=TestWebKitAPI.WKInspectorExtensionDelegate.InspectedPageNavigatedCallbacks&test=TestWebKitAPI.WKInspectorExtensionDelegate.ShowAndHideTabCallbacks&test=TestWebKitAPI.WKInspectorExtensionHost.RegisterExtension&test=TestWebKitAPI.WKInspectorExtensionHost.UnregisterExtension
(In reply to Wenson Hsieh from comment #8) > It seems like several `TestWebKitAPI.WKInspectorExtension*` API tests > started failing or timing out after this change: > > https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api- > tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api- > tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI. > WKInspectorExtension.CanEvaluateScriptInExtensionTab&test=TestWebKitAPI. > WKInspectorExtension. > EvaluateScriptInExtensionTabCanReturnPromises&test=TestWebKitAPI. > WKInspectorExtension.EvaluateScriptOnPage&test=TestWebKitAPI. > WKInspectorExtension.ExtensionTabIsPersistent&test=TestWebKitAPI. > WKInspectorExtensionDelegate. > ExtensionTabNavigatedCallbacks&test=TestWebKitAPI. > WKInspectorExtensionDelegate. > InspectedPageNavigatedCallbacks&test=TestWebKitAPI. > WKInspectorExtensionDelegate.ShowAndHideTabCallbacks&test=TestWebKitAPI. > WKInspectorExtensionHost.RegisterExtension&test=TestWebKitAPI. > WKInspectorExtensionHost.UnregisterExtension Odd. Will take a look.
The TestWebKitAPI content triggers ASSERT(partialRun->length); in InlineContentBreaker::tryBreakingPreviousNonOverflowingRuns Interesting. Fixing it...
(In reply to zalan from comment #10) > The TestWebKitAPI content triggers ASSERT(partialRun->length); in > InlineContentBreaker::tryBreakingPreviousNonOverflowingRuns > Interesting. Fixing it... Nope, the inspector content triggers the assert and not the test content.
bug 235286
(In reply to Wenson Hsieh from comment #8) > It seems like several `TestWebKitAPI.WKInspectorExtension*` API tests > started failing or timing out after this change: > > https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api- > tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api- > tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI. > WKInspectorExtension.CanEvaluateScriptInExtensionTab&test=TestWebKitAPI. > WKInspectorExtension. > EvaluateScriptInExtensionTabCanReturnPromises&test=TestWebKitAPI. > WKInspectorExtension.EvaluateScriptOnPage&test=TestWebKitAPI. > WKInspectorExtension.ExtensionTabIsPersistent&test=TestWebKitAPI. > WKInspectorExtensionDelegate. > ExtensionTabNavigatedCallbacks&test=TestWebKitAPI. > WKInspectorExtensionDelegate. > InspectedPageNavigatedCallbacks&test=TestWebKitAPI. > WKInspectorExtensionDelegate.ShowAndHideTabCallbacks&test=TestWebKitAPI. > WKInspectorExtensionHost.RegisterExtension&test=TestWebKitAPI. > WKInspectorExtensionHost.UnregisterExtension https://trac.webkit.org/changeset/288095/webkit should take care of these failures. Thanks!
*** Bug 218510 has been marked as a duplicate of this bug. ***
*** Bug 218930 has been marked as a duplicate of this bug. ***
*** Bug 226474 has been marked as a duplicate of this bug. ***
*** Bug 217421 has been marked as a duplicate of this bug. ***
*** Bug 217946 has been marked as a duplicate of this bug. ***
*** Bug 197277 has been marked as a duplicate of this bug. ***
*** Bug 197409 has been marked as a duplicate of this bug. ***
*** Bug 197411 has been marked as a duplicate of this bug. ***
*** Bug 224590 has been marked as a duplicate of this bug. ***
*** Bug 193491 has been marked as a duplicate of this bug. ***
*** Bug 230414 has been marked as a duplicate of this bug. ***
*** Bug 232910 has been marked as a duplicate of this bug. ***