Bug 226474 - [GTK] fast/text/letter-spacing-produces-nan-width-crash-log.txt crashes with an assertion
Summary: [GTK] fast/text/letter-spacing-produces-nan-width-crash-log.txt crashes with ...
Status: RESOLVED DUPLICATE of bug 235266
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-31 12:52 PDT by Arcady Goldmints-Orlov
Modified: 2022-01-17 09:38 PST (History)
7 users (show)

See Also:

Attachments
Backtrace (18.17 KB, text/plain)
2021-05-31 12:52 PDT, Arcady Goldmints-Orlov 		no flags Details
Patch (1.43 KB, patch)
2021-06-01 14:54 PDT, Arcady Goldmints-Orlov 		no flags Details | Formatted Diff | Diff
Patch (1.46 KB, patch)
2021-06-02 09:53 PDT, Arcady Goldmints-Orlov 		no flags Details | Formatted Diff | Diff
Patch (1.46 KB, patch)
2021-06-02 10:53 PDT, Arcady Goldmints-Orlov 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arcady Goldmints-Orlov 2021-05-31 12:52:23 PDT 
Created attachment 430210 [details]
Backtrace

Running the test in a debug build of the GTK minibrowser, there is an assertion tripped:

STDERR: ASSERTION FAILED: measuredWidth >= 0
STDERR: ../../Source/WebCore/rendering/ComplexLineLayout.cpp(536) : void WebCore::setLogicalWidthForTextRun(WebCore::RootInlineBox*, WebCore::BidiRun*, WebCore::RenderText&, float, const WebCore::LineInfo&, WebCore::GlyphOverflowAndFallbackFontsMap&, WebCore::VerticalPositionCache&, WebCore::WordMeasurements&)

This test was added in bug221628 and intentionally creates a NaN by combining a very large zoom with a letter-spacing of zero. The bugfix fixed this issue for other platforms by replacing a NaN with 0 in certain places but this is apparently not sufficient for GTK.
Comment 1 Arcady Goldmints-Orlov 2021-06-01 14:54:45 PDT 
Created attachment 430293 [details]
Patch
Comment 2 Arcady Goldmints-Orlov 2021-06-02 09:53:48 PDT 
Created attachment 430368 [details]
Patch
Comment 3 Arcady Goldmints-Orlov 2021-06-02 10:53:58 PDT 
Created attachment 430376 [details]
Patch
Comment 4 EWS 2021-06-15 07:12:47 PDT 
Committed r278871 (238815@main): <https://commits.webkit.org/238815@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430376 [details].
Comment 5 Radar WebKit Bug Importer 2021-06-15 07:13:27 PDT 
<rdar://problem/79341114>
Comment 6 Arcady Goldmints-Orlov 2021-06-15 07:55:42 PDT 
Reopening to track the actual fix.
Comment 7 Arcady Goldmints-Orlov 2022-01-17 09:38:51 PST 
This has been fixed by r288070 allowing LFC integration to work with the complex text path.

*** This bug has been marked as a duplicate of bug 235266 ***