Bug 234657 - RemoteInspectorProtocolHandler::inspect() expects ConnectionID as uint32_t
Summary: RemoteInspectorProtocolHandler::inspect() expects ConnectionID as uint32_t
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-23 19:02 PST by Yousuke Kimoto
Modified: 2021-12-26 15:13 PST (History)
11 users (show)

See Also:

Attachments
Patch (1.64 KB, patch)
2021-12-23 19:25 PST, Yousuke Kimoto 		no flags Details | Formatted Diff | Diff
Patch (1.65 KB, patch)
2021-12-26 10:07 PST, Yousuke Kimoto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuke Kimoto 2021-12-23 19:02:52 PST 
https://bugs.webkit.org/show_bug.cgi?id=197243 fixed connection and target identifier types.

ConnectionID is 
  using ConnectionID = uint32_t;

But currently connectionID is given to RemoteInspectorProtocolHandler::inspect() as "int" by the commit https://github.com/WebKit/WebKit/commit/695e0888fe0472f49fdc27da5f57d0f5e4353e51

  m_inspectorProtocolHandler.inspect(requestURL.hostAndPort(), parseInteger<int>(tokens[0]).value_or(0), parseInteger<int>(tokens[1]).value_or(0), tokens[2]);

It should be "uint32_t".
Comment 1 Yousuke Kimoto 2021-12-23 19:25:20 PST 
Created attachment 447928 [details]
Patch
Comment 2 Yousuke Kimoto 2021-12-26 10:07:02 PST 
Created attachment 447976 [details]
Patch

The previous patch was wrong. The second parseInteger() should also be casted with "uint32_t".
Comment 3 EWS 2021-12-26 15:12:42 PST 
Committed r287450 (245585@main): <https://commits.webkit.org/245585@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447976 [details].
Comment 4 Radar WebKit Bug Importer 2021-12-26 15:13:17 PST 
<rdar://problem/86923496>