Bug 197243 – [RemoteInspector] Fix connection and target identifier types.

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Basuke Suzuki]

The type ClientID and connection id delivered in the event body is interchangeable so that they have to be same type.

[Basuke Suzuki]

Created attachment 368174 [details]
PATCH

[Don Olmstead]

Comment on attachment 368174 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=368174&action=review

> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorConnectionClient.cpp:65
> +    unsigned targetID;

Do you want to do the same to TargetID while you're here?

[Basuke Suzuki]

Sure.

[Basuke Suzuki]

Created attachment 368189 [details]
PATCH

[Ross Kirsling]

Comment on attachment 368189 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=368189&action=review

> Source/JavaScriptCore/inspector/remote/RemoteControllableTarget.h:41
> +using TargetID = unsigned;

Should this be changed to uint32_t as well?

[Basuke Suzuki]

(In reply to Ross Kirsling from comment #5)
> Comment on attachment 368189 [details]
> PATCH
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=368189&action=review
> 
> > Source/JavaScriptCore/inspector/remote/RemoteControllableTarget.h:41
> > +using TargetID = unsigned;
> 
> Should this be changed to uint32_t as well?

I intentionally leave that as is because there's no assumption that `unsigned` is  uint32_t (of course it is correct for known compilers).

[Basuke Suzuki]

Created attachment 368193 [details]
Test for GTK/WPE and Mac/iOS build

[Basuke Suzuki]

Created attachment 368249 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 368249 [details]
Patch for landing

Clearing flags on attachment: 368249

Committed r244657: <https://trac.webkit.org/changeset/244657>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50213703>