Bug 197243 - [RemoteInspector] Fix connection and target identifier types.
Summary: [RemoteInspector] Fix connection and target identifier types.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-24 13:50 PDT by Basuke Suzuki
Modified: 2019-04-25 11:55 PDT (History)
13 users (show)

See Also:


Attachments
PATCH (23.24 KB, patch)
2019-04-24 14:01 PDT, Basuke Suzuki
no flags Details | Formatted Diff | Diff
PATCH (43.86 KB, patch)
2019-04-24 15:21 PDT, Basuke Suzuki
no flags Details | Formatted Diff | Diff
Test for GTK/WPE and Mac/iOS build (39.12 KB, patch)
2019-04-24 15:46 PDT, Basuke Suzuki
no flags Details | Formatted Diff | Diff
Patch for landing (44.21 KB, patch)
2019-04-25 11:03 PDT, Basuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2019-04-24 13:50:49 PDT
The type ClientID and connection id delivered in the event body is interchangeable so that they have to be same type.
Comment 1 Basuke Suzuki 2019-04-24 14:01:12 PDT
Created attachment 368174 [details]
PATCH
Comment 2 Don Olmstead 2019-04-24 14:20:40 PDT
Comment on attachment 368174 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=368174&action=review

> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorConnectionClient.cpp:65
> +    unsigned targetID;

Do you want to do the same to TargetID while you're here?
Comment 3 Basuke Suzuki 2019-04-24 14:32:14 PDT
Sure.
Comment 4 Basuke Suzuki 2019-04-24 15:21:34 PDT
Created attachment 368189 [details]
PATCH
Comment 5 Ross Kirsling 2019-04-24 15:33:00 PDT
Comment on attachment 368189 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=368189&action=review

> Source/JavaScriptCore/inspector/remote/RemoteControllableTarget.h:41
> +using TargetID = unsigned;

Should this be changed to uint32_t as well?
Comment 6 Basuke Suzuki 2019-04-24 15:41:46 PDT
(In reply to Ross Kirsling from comment #5)
> Comment on attachment 368189 [details]
> PATCH
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=368189&action=review
> 
> > Source/JavaScriptCore/inspector/remote/RemoteControllableTarget.h:41
> > +using TargetID = unsigned;
> 
> Should this be changed to uint32_t as well?

I intentionally leave that as is because there's no assumption that `unsigned` is  uint32_t (of course it is correct for known compilers).
Comment 7 Basuke Suzuki 2019-04-24 15:46:10 PDT
Created attachment 368193 [details]
Test for GTK/WPE and Mac/iOS build
Comment 8 Basuke Suzuki 2019-04-25 11:03:56 PDT
Created attachment 368249 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2019-04-25 11:54:23 PDT
Comment on attachment 368249 [details]
Patch for landing

Clearing flags on attachment: 368249

Committed r244657: <https://trac.webkit.org/changeset/244657>
Comment 10 WebKit Commit Bot 2019-04-25 11:54:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2019-04-25 11:55:35 PDT
<rdar://problem/50213703>