Bug 234648 - Web Inspector: blackboxed call frames should be grouped everywhere
Summary: Web Inspector: blackboxed call frames should be grouped everywhere
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 234581
  Show dependency treegraph
 
Reported: 2021-12-23 13:46 PST by Devin Rousso
Modified: 2022-01-19 14:39 PST (History)
5 users (show)

See Also:


Attachments
Patch (35.03 KB, patch)
2022-01-15 18:31 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (34.00 KB, patch)
2022-01-19 12:07 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-12-23 13:46:56 PST
# STEPS TO REPRODUCE
1. inspect <http://bogojoker.com/shell/>
2. create a "click" global Event Breakpoint
3. blackbox the <http://bogojoker.com/shell/js/jquery.js> script
4. click on the down arrow in the page
-> should pause on <http://bogojoker.com/shell/js/easySlider.min.js:64> with two blackboxed call frames
5. evaluate `console.trace()`

## EXPECTED
(anonymous function) (easySlider.min.js:56)
Blackboxed - 2 call frames

## ACTUAL
(anonymous function) (easySlider.min.js:56)
handle (jquery.js:26:2120)
(anonymous function) (jquery.js:25:11369)
Comment 1 Radar WebKit Bug Importer 2021-12-30 13:47:20 PST
<rdar://problem/87018103>
Comment 2 Devin Rousso 2022-01-15 18:31:55 PST
Created attachment 449279 [details]
Patch
Comment 3 Patrick Angle 2022-01-19 10:53:06 PST
Comment on attachment 449279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449279&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/StackTrace.js:163
> +                firstNonNativeNonAnonymousCallFrame ??= frame;

Nice catch. It's a bit concerning that we don't seem to test this anywhere, though.
Comment 4 Devin Rousso 2022-01-19 11:51:50 PST
Comment on attachment 449279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449279&action=review

>> Source/WebInspectorUI/UserInterface/Models/StackTrace.js:163
>> +                firstNonNativeNonAnonymousCallFrame ??= frame;
> 
> Nice catch. It's a bit concerning that we don't seem to test this anywhere, though.

Good point!  I'll add a test for this :)

And actually, I'll split this into a separate bug.
Comment 5 Devin Rousso 2022-01-19 12:07:05 PST
Created attachment 449505 [details]
Patch
Comment 6 EWS 2022-01-19 14:39:29 PST
Committed r288243 (246196@main): <https://commits.webkit.org/246196@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449505 [details].