Bug 234648 – Web Inspector: blackboxed call frames should be grouped everywhere

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE
1. inspect <http://bogojoker.com/shell/>
2. create a "click" global Event Breakpoint
3. blackbox the <http://bogojoker.com/shell/js/jquery.js> script
4. click on the down arrow in the page
-> should pause on <http://bogojoker.com/shell/js/easySlider.min.js:64> with two blackboxed call frames
5. evaluate `console.trace()`

## EXPECTED
(anonymous function) (easySlider.min.js:56)
Blackboxed - 2 call frames

## ACTUAL
(anonymous function) (easySlider.min.js:56)
handle (jquery.js:26:2120)
(anonymous function) (jquery.js:25:11369)

[Radar WebKit Bug Importer]

<rdar://problem/87018103>

[Devin Rousso]

Created attachment 449279 [details]
Patch

[Patrick Angle]

Comment on attachment 449279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449279&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/StackTrace.js:163
> +                firstNonNativeNonAnonymousCallFrame ??= frame;

Nice catch. It's a bit concerning that we don't seem to test this anywhere, though.

[Devin Rousso]

Comment on attachment 449279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449279&action=review

>> Source/WebInspectorUI/UserInterface/Models/StackTrace.js:163
>> +                firstNonNativeNonAnonymousCallFrame ??= frame;
> 
> Nice catch. It's a bit concerning that we don't seem to test this anywhere, though.

Good point!  I'll add a test for this :)

And actually, I'll split this into a separate bug.

[Devin Rousso]

Created attachment 449505 [details]
Patch

[EWS]

Committed r288243 (246196@main): <https://commits.webkit.org/246196@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449505 [details].