Bug 234581 - Web Inspector: Collapse blackboxed call frames by default
Summary: Web Inspector: Collapse blackboxed call frames by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on: 219806 234614 234615 234648
Blocks:
  Show dependency tree / graph
 
Reported: 2021-12-21 16:27 PST by Nikita Vasilyev
Modified: 2022-01-25 16:25 PST (History)
5 users (show)

See Also:

Attachments
Patch (11.29 KB, patch)
2021-12-21 17:19 PST, Nikita Vasilyev 		hi: review-
nvasilyev: commit-queue-
Details | Formatted Diff | Diff
Patch (7.51 KB, patch)
2022-01-25 12:00 PST, Nikita Vasilyev 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2021-12-21 16:27:53 PST 
Currently, "Collapse blackboxed call frames" is an experimental feature. Enable it by default.
Comment 1 Nikita Vasilyev 2021-12-21 17:19:00 PST 
Created attachment 447767 [details]
Patch

cq- for now because I'd like to hold on landing this just before the holidays.
Comment 2 Devin Rousso 2021-12-22 12:58:21 PST 
Comment on attachment 447767 [details]
Patch

r-, I just tried using this after a while and ran across a couple things I think should be addressed before enabling this by default
Comment 3 Radar WebKit Bug Importer 2021-12-28 16:28:18 PST 
<rdar://problem/86967088>
Comment 4 Nikita Vasilyev 2022-01-25 12:00:25 PST 
Created attachment 449948 [details]
Patch
Comment 5 Devin Rousso 2022-01-25 12:19:43 PST 
Comment on attachment 449948 [details]
Patch

r=me, 🎉
Comment 6 EWS 2022-01-25 13:37:11 PST 
Committed r288580 (246402@main): <https://commits.webkit.org/246402@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449948 [details].