A few more bugs in the recent config file changes for alternate root builds. - For frameworks nested under the WebCore framework, for macOS the directory needs to include the version, e.g. WebCore.framework/Versions/A/Frameworks instead of WebCore.framework/Frameworks. - WebKit needs to have SYSTEM_CONTENT_PATH added to the nested frameworks path (UMBRELLA_FRAMEWORKS_DIR). - WebCore and WebKitLegacy framework locations needs to have the SYSTEM_CONTENT_PATH added.
<rdar://86828224>
Created attachment 447848 [details] Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment on attachment 447848 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447848&action=review > Source/ThirdParty/ANGLE/ChangeLog:9 > + Deleted unussed create-symlink-to-altroot.sh script. Typo: "unussed"
(In reply to Jessie Berlin from comment #4) > Comment on attachment 447848 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447848&action=review > > > Source/ThirdParty/ANGLE/ChangeLog:9 > > + Deleted unussed create-symlink-to-altroot.sh script. > > Typo: "unussed" Fixed locally.
Committed r287382 (?): <https://commits.webkit.org/r287382>
Comment on attachment 447848 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447848&action=review > Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:35 > +INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_YES = $(SYSTEM_CONTENT_PATH)$(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks; What makes this macOS specific?
> What makes this macOS specific? Fixing this is tracked as bug 234857 now.