Bug 234857 - REGRESSION (r287382): libANGLE is built into a wrong location on iOS
Summary: REGRESSION (r287382): libANGLE is built into a wrong location on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-04 12:55 PST by Michael Saboff
Modified: 2022-01-05 11:42 PST (History)
8 users (show)

See Also:

Attachments
Patch (5.86 KB, patch)
2022-01-04 15:54 PST, Michael Saboff 		saam: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2022-01-04 12:55:36 PST 
r287382 made libANGLE go into /System/Library/PrivateFrameworks/WebCore.framework/Versions/A/Frameworks on iOS, which is obviously wrong (there is no Versions/A on iOS).
Comment 1 Michael Saboff 2022-01-04 12:55:56 PST 
<rdar://87072368>
Comment 2 Michael Saboff 2022-01-04 13:30:56 PST 
libwebrtc isn't installed in the wrong place, but libwebrtc.xcconfig has some similar bad logic in it.
Comment 3 Michael Saboff 2022-01-04 15:54:04 PST 
Created attachment 448342 [details]
Patch
Comment 4 EWS Watchlist 2022-01-04 15:55:10 PST 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 5 Michael Saboff 2022-01-05 11:35:07 PST 
The mac-debug-wk1 test that EWS flagged, imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-007.html, has a flakey history and the patch changes were build product location related.
Comment 6 Michael Saboff 2022-01-05 11:42:51 PST 
Committed r287642 (245746@trunk): <https://commits.webkit.org/245746@trunk>