[Win] MSVC reports "DumpRenderTree.cpp(633): error C2362: initialization of 'length' is skipped by 'goto exit'" with /std:c++20 > Tools\DumpRenderTree\win\DumpRenderTree.cpp(633): error C2362: initialization of 'length' is skipped by 'goto exit' > Tools\DumpRenderTree\win\DumpRenderTree.cpp(611): note: see declaration of 'length' > Tools\DumpRenderTree\win\DumpRenderTree.cpp(633): note: see declaration of 'exit'
Created attachment 447583 [details] Patch
Created attachment 447621 [details] Patch r287297
Comment on attachment 447621 [details] Patch r287297 Clearing flags on attachment: 447621 Committed r287297 (245449@trunk): <https://commits.webkit.org/245449@trunk>
All reviewed patches have been landed. Closing bug.
<rdar://problem/86752706>
Comment on attachment 447621 [details] Patch r287297 View in context: https://bugs.webkit.org/attachment.cgi?id=447621&action=review > Tools/DumpRenderTree/win/DumpRenderTree.cpp:597 > + SAFEARRAY* arraryPtr; "array" is good, but "arrary" not so good > Tools/DumpRenderTree/win/DumpRenderTree.cpp:605 > + std::unique_ptr<SAFEARRAY, decltype(deleter)> array(arraryPtr, deleter); I suspect we can rely on deduction guides and just write std::unique_ptr here without the template arguments.
Reopened.
Created attachment 447766 [details] Patch
Comment on attachment 447766 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447766&action=review > Tools/DumpRenderTree/win/DumpRenderTree.cpp:602 > + if (SUCCEEDED(::SafeArrayUnlock(arrayPtr))) This code has another bug. I'm going to fix this typo and the bug in the following ticket. Bug 234870 – [Win][DumpRenderTree] dumpHistoryItem leaks a SafeArray