Bug 234870 - [Win][DumpRenderTree] dumpHistoryItem leaks a SafeArray
Summary: [Win][DumpRenderTree] dumpHistoryItem leaks a SafeArray
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-04 22:38 PST by Fujii Hironori
Modified: 2022-01-05 00:04 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2022-01-04 22:52 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-01-04 22:38:14 PST 
[Win][DumpRenderTree] dumpHistoryItem leaks a SafeArray

r23462 added the following code.

> if (arrPtr && SUCCEEDED(::SafeArrayUnlock(arrPtr)))
>     ::SafeArrayDestroy(arrPtr);

However, the array isn't locked. Thus, SafeArrayUnlock fails.
SafeArrayDestroy isn't called.
Comment 1 Fujii Hironori 2022-01-04 22:42:50 PST 
r23321 added the code.
Comment 2 Fujii Hironori 2022-01-04 22:52:20 PST 
Created attachment 448360 [details]
Patch
Comment 3 EWS 2022-01-05 00:03:55 PST 
Committed r287605 (245732@main): <https://commits.webkit.org/245732@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448360 [details].
Comment 4 Radar WebKit Bug Importer 2022-01-05 00:04:31 PST 
<rdar://problem/87133401>