Bug 234481 - [libpas] Add macros to disable bmalloc core so that libpas can be enabled on 64-bit watchOS
Summary: [libpas] Add macros to disable bmalloc core so that libpas can be enabled on ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 234416 234478
Blocks:
  Show dependency treegraph
 
Reported: 2021-12-18 15:00 PST by David Kilzer (:ddkilzer)
Modified: 2021-12-19 12:35 PST (History)
4 users (show)

See Also:


Attachments
Patch (60.25 KB, patch)
2021-12-19 00:19 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (60.31 KB, patch)
2021-12-19 01:25 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2021-12-18 15:00:49 PST
Add macros to disable bmalloc core so that libpas can be enabled on 64-bit watchOS.

Bug 234416 enabled libpas on all 64-bit Apple platforms, but it didn't disable the core bmalloc code it replaced, so it caused a disk/shared memory regression of about 6 MB on arm64e on watchOS (and likely other OSes/architectures).

This bug is to add guards to core bmalloc code that libpas replaces so that it can be disabled at compile time (at least on watchOS), which would let us enable libpas on watchOS once again.

Note that Bug 234478 turned off libpas on 64-bit watchOS.
Comment 1 Radar WebKit Bug Importer 2021-12-18 15:01:29 PST
<rdar://problem/86675567>
Comment 2 Yusuke Suzuki 2021-12-19 00:19:09 PST
Created attachment 447544 [details]
Patch
Comment 3 Yusuke Suzuki 2021-12-19 01:25:39 PST
Created attachment 447546 [details]
Patch
Comment 4 David Kilzer (:ddkilzer) 2021-12-19 08:30:15 PST
Comment on attachment 447546 [details]
Patch

r=me!  The mac-debug-wk1 failures I've seen on another patch--they aren't related.
Comment 5 EWS 2021-12-19 12:35:22 PST
Committed r287246 (245404@main): <https://commits.webkit.org/245404@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447546 [details].