Bug 234478 – [libpas] Do not compile libpas for 64-bit watchOS to save ~6 MB per architecture

• Status: RESOLVED
• Resolution: FIXED
• Component: bmalloc

[David Kilzer (:ddkilzer)]

Do not compile libpas for watchOS arm64e to save 6.15 MB.

<rdar://85620647>

[David Kilzer (:ddkilzer)]

Also going to disable it for tvOS to save space as it's not currently used there to my knowledge.

[David Kilzer (:ddkilzer)]

Commit r287175 enabled libpas on all iOS family 64-bit architectures:

    [libpas] Enable libpas on ARM64 Darwin platforms (ARM64E is already enabled)
    https://bugs.webkit.org/show_bug.cgi?id=234416
    https://commits.webkit.org/r287175

But the core of bmalloc itself is still compiled into the build, which means 64-bit watchOS architectures now consume an additional ~6 MB for libpas.

[David Kilzer (:ddkilzer)]

Created attachment 447532 [details]
Patch v1

[Yusuke Suzuki]

Comment on attachment 447532 [details]
Patch v1

r=me

[Yusuke Suzuki]

Does watchOS include ARM64E slice? I thought it is only having ARM64_32 and ARMv7k.

[David Kilzer (:ddkilzer)]

(In reply to Yusuke Suzuki from comment #5)
> Does watchOS include ARM64E slice? I thought it is only having ARM64_32 and
> ARMv7k.

Yes, watchOS has three slices, including arm64e.

[David Kilzer (:ddkilzer)]

Comment on attachment 447532 [details]
Patch v1

Adding cq+ since all Apple platforms have built.

[EWS]

Committed r287233 (245393@main): <https://commits.webkit.org/245393@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447532 [details].