TestWebKitAPI.GraphicsContextGLCocoaTest.UnrecycledDisplayBuffersNoLeaks is failing on arm64 macOS bots after https://trac.webkit.org/changeset/287068/webkit, x86 bots are not affected. TestWebKitAPI.GraphicsContextGLCocoaTest.UnrecycledDisplayBuffersNoLeaks /Volumes/Data/worker/monterey-release/build/Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm:242 Value of: memoryFootprintChangedBy(lastFootprint, footprintChange, footprintError) Actual: false (Footprint changed by 827590144. Expected at most 0+-157286400) Expected: true https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.GraphicsContextGLCocoaTest.UnrecycledDisplayBuffersNoLeaks
<rdar://problem/86533892>
To be clear: that commit was the ANGLE roll to 2021-12-14 in Bug 234317. We'd strongly prefer to not revert that roll. Is there any indication what might have caused this?
(In reply to Kenneth Russell from comment #2) > To be clear: that commit was the ANGLE roll to 2021-12-14 in Bug 234317. > > We'd strongly prefer to not revert that roll. Is there any indication what > might have caused this? Kyle is investigating.
I cannot attend to it until tomorrow. If it's a problem, naming it DISABLED_Unrecycled.. would skip it temporarily
Created attachment 447348 [details] Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment on attachment 447348 [details] Patch LGTM, great catch.
Amazing work Kimmo tracking this down! r+ from me as well.
Filed https://bugs.chromium.org/p/angleproject/issues/detail?id=6829 about upstreaming this to ANGLE. I'll help with that.
kpiddington@apple.com does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json. Rejecting attachment 447348 [details] from commit queue.
Comment on attachment 447348 [details] Patch rs=me, actual review by Kyle Piddington
Committed r287178 (245347@main): <https://commits.webkit.org/245347@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447348 [details].
For bookkeeping purposes, the new test was added under Bug 233328.