Bug 234356 – REGRESSION (r287068): [macOS arm64] TestWebKitAPI.GraphicsContextGLCocoaTest.UnrecycledDisplayBuffersNoLeaks is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: ANGLE

[Ryan Haddad]

TestWebKitAPI.GraphicsContextGLCocoaTest.UnrecycledDisplayBuffersNoLeaks is failing on arm64 macOS bots after https://trac.webkit.org/changeset/287068/webkit, x86 bots are not affected.

    TestWebKitAPI.GraphicsContextGLCocoaTest.UnrecycledDisplayBuffersNoLeaks
        
        /Volumes/Data/worker/monterey-release/build/Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm:242
        Value of: memoryFootprintChangedBy(lastFootprint, footprintChange, footprintError)
          Actual: false (Footprint changed by 827590144. Expected at most 0+-157286400)
        Expected: true

https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.GraphicsContextGLCocoaTest.UnrecycledDisplayBuffersNoLeaks

[Radar WebKit Bug Importer]

<rdar://problem/86533892>

[Kenneth Russell]

To be clear: that commit was the ANGLE roll to 2021-12-14 in Bug 234317.

We'd strongly prefer to not revert that roll. Is there any indication what might have caused this?

[Ryan Haddad]

(In reply to Kenneth Russell from comment #2)
> To be clear: that commit was the ANGLE roll to 2021-12-14 in Bug 234317.
> 
> We'd strongly prefer to not revert that roll. Is there any indication what
> might have caused this?
Kyle is investigating.

[Kimmo Kinnunen]

I cannot attend to it until tomorrow. If it's a problem, naming it DISABLED_Unrecycled.. would skip it temporarily

[Kimmo Kinnunen]

Created attachment 447348 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Kyle Piddington]

Comment on attachment 447348 [details]
Patch

LGTM, great catch.

[Kenneth Russell]

Amazing work Kimmo tracking this down! r+ from me as well.

[Kenneth Russell]

Filed https://bugs.chromium.org/p/angleproject/issues/detail?id=6829 about upstreaming this to ANGLE. I'll help with that.

[EWS]

[e-mail] does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json.

Rejecting attachment 447348 [details] from commit queue.

[Antti Koivisto]

Comment on attachment 447348 [details]
Patch

rs=me, actual review by Kyle Piddington

[EWS]

Committed r287178 (245347@main): <https://commits.webkit.org/245347@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447348 [details].

[Kenneth Russell]

For bookkeeping purposes, the new test was added under Bug 233328.