Bug 234317 - [ANGLE] Roll ANGLE to 12-14-2021 (36fcf80b1f2)
Summary: [ANGLE] Roll ANGLE to 12-14-2021 (36fcf80b1f2)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kyle Piddington
URL:
Keywords: InRadar
Depends on:
Blocks: 234356
  Show dependency treegraph
 
Reported: 2021-12-14 14:24 PST by Kyle Piddington
Modified: 2021-12-15 12:00 PST (History)
11 users (show)

See Also:


Attachments
Patch (1.72 MB, patch)
2021-12-14 14:30 PST, Kyle Piddington
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (1.63 MB, patch)
2021-12-14 15:18 PST, Kyle Piddington
no flags Details | Formatted Diff | Diff
Patch (1.63 MB, patch)
2021-12-14 17:18 PST, Kyle Piddington
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (1.63 MB, patch)
2021-12-14 17:43 PST, Kyle Piddington
no flags Details | Formatted Diff | Diff
Patch for landing (1.63 MB, patch)
2021-12-15 01:08 PST, Kyle Piddington
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Piddington 2021-12-14 14:24:03 PST
Rolling ANGLE forward to include merge-up changes, ContextMTLDevice for memory tracking.
Comment 1 Kyle Piddington 2021-12-14 14:30:02 PST
Created attachment 447164 [details]
Patch
Comment 2 EWS Watchlist 2021-12-14 14:31:18 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kenneth Russell 2021-12-14 14:48:45 PST
Comment on attachment 447164 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447164&action=review

Reviewed all of changes.diff and the Metal backend changes.

A few comments, but nothing that should block integration. Let's move forward to unblock John Cunningham's work, and others. r+

> Source/ThirdParty/ANGLE/changes.diff:549
> + 

Can this whitespace change be removed? It looks like it would eliminate a diff block.

> Source/ThirdParty/ANGLE/changes.diff:571
> +-

Can this whitespace difference be removed?

> Source/ThirdParty/ANGLE/changes.diff:-1081
> --    if (ANGLE_APPLE_AVAILABLE_XI(10.15, 13.0))

We should roll forward to include your https://chromium-review.googlesource.com/c/angle/angle/+/3338624 ASAP - otherwise we'll lose ETC/ASTC support on M1 Macs in Safari, too.

> Source/ThirdParty/ANGLE/changes.diff:885
> + def gen_image_map_switch_string(image_table, angle_to_gl):

What causes this large diff in the format table generator? Can this be investigated and resolved?

> Source/ThirdParty/ANGLE/changes.diff:1171
> +@@ -161,7 +159,7 @@

Additionally - what causes all the diffs in this generated file compared to upstream?

> Source/ThirdParty/ANGLE/changes.diff:-3976
> -+        

Can this whitespace diff be removed?

> Source/ThirdParty/ANGLE/changes.diff:2404
> ++        variable_name, output_file))

Can these formatting changes be reconciled?

> Source/ThirdParty/ANGLE/changes.diff:2411
> ++

Can this whitespace change be removed?

> Source/ThirdParty/ANGLE/changes.diff:2419
> ++        'echo "// Compiled binary for Metal default shaders.\n\n" >>  \"{0}\"'.format(output_file))

Can this formatting difference be reconciled?

> Source/ThirdParty/ANGLE/changes.diff:2423
> ++

Can this whitespace change be reconciled?
Comment 4 Kyle Piddington 2021-12-14 15:18:19 PST
Created attachment 447169 [details]
Patch
Comment 5 Kyle Piddington 2021-12-14 17:18:31 PST
Created attachment 447181 [details]
Patch
Comment 6 Kyle Piddington 2021-12-14 17:43:16 PST
Created attachment 447184 [details]
Patch
Comment 7 Kyle Piddington 2021-12-15 01:08:04 PST
Created attachment 447209 [details]
Patch for landing
Comment 8 EWS 2021-12-15 01:44:17 PST
Committed r287068 (245263@main): <https://commits.webkit.org/245263@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447209 [details].
Comment 9 Radar WebKit Bug Importer 2021-12-15 01:45:36 PST
<rdar://problem/86512440>