Bug 234105 - REGRESSION (r286259): [ BigSur+ wk1 ] 2X imported/w3c/web-platform-tests/speech-api/SpeechSynthesis (layout-tests) are constant text failures
Summary: REGRESSION (r286259): [ BigSur+ wk1 ] 2X imported/w3c/web-platform-tests/spee...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-09 14:44 PST by Robert Jenner
Modified: 2021-12-14 13:49 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Jenner 2021-12-09 14:44:06 PST
The following two tests are constant text failures on Big Sur and later in WK 1:

imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-speak-events.html
imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-pause-resume.tentative.html

HISTORY:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fspeech-api%2FSpeechSynthesis-pause-resume.tentative.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fspeech-api%2FSpeechSynthesis-speak-events.html


DIF URLS:
https://build.webkit.org/results/Apple-Monterey-Release-WK1-Tests/r286796%20(580)/imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-pause-resume.tentative-pretty-diff.html
https://build.webkit.org/results/Apple-Monterey-Release-WK1-Tests/r286796%20(580)/imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-speak-events-pretty-diff.html

TEXT DIFFS:
FOR "imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-pause-resume.tentative.html":
 
-PASS speechSynthesis.pause() and resume() state and events
+Harness Error (TIMEOUT), message = null
 
+TIMEOUT speechSynthesis.pause() and resume() state and events Test timed out
+



FOR "imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-speak-events.html":
-FAIL speechSynthesis.speak() fires start and end events with empty utterance assert_true: Not expecting event, but got end event expected true got false
+FAIL speechSynthesis.speak() fires start and end events with empty utterance assert_true: Not expecting event, but got start event expected true got false
 FAIL speechSynthesis.speak() fires start and end events assert_true: Not expecting event, but got start event expected true got false
Comment 1 Radar WebKit Bug Importer 2021-12-09 14:44:30 PST
<rdar://problem/86292065>
Comment 2 Robert Jenner 2021-12-09 14:56:20 PST
I was able to reproduce the failure at Monterey Production ToT using the following test:

run-webkit-tests <test name goes here> -1 



I was able to also discover the regression point. The history shows that these tests weren't running on wk1 prior to r286259. When I ran the same test at r286258, I found that the tests were passing. They started failing after the introduction of r286259:

https://trac.webkit.org/changeset/286259/webkit
Comment 3 chris fleizach 2021-12-09 15:01:34 PST
(In reply to Robert Jenner from comment #2)
> I was able to reproduce the failure at Monterey Production ToT using the
> following test:
> 
> run-webkit-tests <test name goes here> -1 
> 
> 
> 
> I was able to also discover the regression point. The history shows that
> these tests weren't running on wk1 prior to r286259. When I ran the same
> test at r286258, I found that the tests were passing. They started failing
> after the introduction of r286259:
> 
> https://trac.webkit.org/changeset/286259/webkit

I re-enabled them with this change, but I'm testing on 12.0. I think we should skip on Big Sur and just run on Monterey if this is the case
Comment 4 Robert Jenner 2021-12-09 17:47:25 PST
(In reply to chris fleizach from comment #3)
> (In reply to Robert Jenner from comment #2)
> > I was able to reproduce the failure at Monterey Production ToT using the
> > following test:
> > 
> > run-webkit-tests <test name goes here> -1 
> > 
> > 
> > 
> > I was able to also discover the regression point. The history shows that
> > these tests weren't running on wk1 prior to r286259. When I ran the same
> > test at r286258, I found that the tests were passing. They started failing
> > after the introduction of r286259:
> > 
> > https://trac.webkit.org/changeset/286259/webkit
> 
> I re-enabled them with this change, but I'm testing on 12.0. I think we
> should skip on Big Sur and just run on Monterey if this is the case



Okay, that sounds good for BigSur. I will get them skipped for wk1 there. 

What should be done for it failing on wk1 Monterey?
Comment 5 chris fleizach 2021-12-09 22:47:16 PST
(In reply to Robert Jenner from comment #4)
> (In reply to chris fleizach from comment #3)
> > (In reply to Robert Jenner from comment #2)
> > > I was able to reproduce the failure at Monterey Production ToT using the
> > > following test:
> > > 
> > > run-webkit-tests <test name goes here> -1 
> > > 
> > > 
> > > 
> > > I was able to also discover the regression point. The history shows that
> > > these tests weren't running on wk1 prior to r286259. When I ran the same
> > > test at r286258, I found that the tests were passing. They started failing
> > > after the introduction of r286259:
> > > 
> > > https://trac.webkit.org/changeset/286259/webkit
> > 
> > I re-enabled them with this change, but I'm testing on 12.0. I think we
> > should skip on Big Sur and just run on Monterey if this is the case
> 
> 
> 
> Okay, that sounds good for BigSur. I will get them skipped for wk1 there. 
> 
> What should be done for it failing on wk1 Monterey?

Can you skip all WK1. I will look into the Monterey case
https://bugs.webkit.org/show_bug.cgi?id=234125

I feel like that should pass without issue
Comment 6 Robert Jenner 2021-12-13 14:05:32 PST
(In reply to chris fleizach from comment #5)
> (In reply to Robert Jenner from comment #4)
> > (In reply to chris fleizach from comment #3)
> > > (In reply to Robert Jenner from comment #2)
> > > > I was able to reproduce the failure at Monterey Production ToT using the
> > > > following test:
> > > > 
> > > > run-webkit-tests <test name goes here> -1 
> > > > 
> > > > 
> > > > 
> > > > I was able to also discover the regression point. The history shows that
> > > > these tests weren't running on wk1 prior to r286259. When I ran the same
> > > > test at r286258, I found that the tests were passing. They started failing
> > > > after the introduction of r286259:
> > > > 
> > > > https://trac.webkit.org/changeset/286259/webkit
> > > 
> > > I re-enabled them with this change, but I'm testing on 12.0. I think we
> > > should skip on Big Sur and just run on Monterey if this is the case
> > 
> > 
> > 
> > Okay, that sounds good for BigSur. I will get them skipped for wk1 there. 
> > 
> > What should be done for it failing on wk1 Monterey?
> 
> Can you skip all WK1. I will look into the Monterey case
> https://bugs.webkit.org/show_bug.cgi?id=234125
> 
> I feel like that should pass without issue


Disabled for all Mac wk1 here:

https://trac.webkit.org/changeset/286980/webkit
Comment 7 chris fleizach 2021-12-13 14:07:43 PST
(In reply to Robert Jenner from comment #6)
> (In reply to chris fleizach from comment #5)
> > (In reply to Robert Jenner from comment #4)
> > > (In reply to chris fleizach from comment #3)
> > > > (In reply to Robert Jenner from comment #2)
> > > > > I was able to reproduce the failure at Monterey Production ToT using the
> > > > > following test:
> > > > > 
> > > > > run-webkit-tests <test name goes here> -1 
> > > > > 
> > > > > 
> > > > > 
> > > > > I was able to also discover the regression point. The history shows that
> > > > > these tests weren't running on wk1 prior to r286259. When I ran the same
> > > > > test at r286258, I found that the tests were passing. They started failing
> > > > > after the introduction of r286259:
> > > > > 
> > > > > https://trac.webkit.org/changeset/286259/webkit
> > > > 
> > > > I re-enabled them with this change, but I'm testing on 12.0. I think we
> > > > should skip on Big Sur and just run on Monterey if this is the case
> > > 
> > > 
> > > 
> > > Okay, that sounds good for BigSur. I will get them skipped for wk1 there. 
> > > 
> > > What should be done for it failing on wk1 Monterey?
> > 
> > Can you skip all WK1. I will look into the Monterey case
> > https://bugs.webkit.org/show_bug.cgi?id=234125
> > 
> > I feel like that should pass without issue
> 
> 
> Disabled for all Mac wk1 here:
> 
> https://trac.webkit.org/changeset/286980/webkit
Thanks for your help