Bug 231895 - AX: Unify speech synthesizer platform usage for Mac/iOS
Summary: AX: Unify speech synthesizer platform usage for Mac/iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-18 08:40 PDT by chris fleizach
Modified: 2021-12-09 14:56 PST (History)
8 users (show)

See Also:


Attachments
patch (33.08 KB, patch)
2021-10-18 08:42 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
patch (33.16 KB, patch)
2021-10-18 08:49 PDT, chris fleizach
andresg_22: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (35.29 KB, patch)
2021-10-20 08:22 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
patch (35.29 KB, patch)
2021-10-20 19:43 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
patch for landing (35.29 KB, patch)
2021-10-21 09:06 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
patch for landing (35.29 KB, patch)
2021-10-21 09:07 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
patch (50.19 KB, patch)
2021-11-27 13:37 PST, chris fleizach
no flags Details | Formatted Diff | Diff
patch (48.46 KB, patch)
2021-11-27 13:40 PST, chris fleizach
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (49.41 KB, patch)
2021-11-27 16:32 PST, chris fleizach
no flags Details | Formatted Diff | Diff
patch (49.59 KB, patch)
2021-11-27 16:33 PST, chris fleizach
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (49.85 KB, patch)
2021-11-27 22:43 PST, chris fleizach
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2021-10-18 08:40:36 PDT
Unify the platform speech synthesizer usage for macOS. Now that AVSpeechSynthesizer has been fully supported for a number of years, we can switch over
Comment 1 Radar WebKit Bug Importer 2021-10-18 08:40:47 PDT
<rdar://problem/84372479>
Comment 2 chris fleizach 2021-10-18 08:42:19 PDT
Created attachment 441606 [details]
patch
Comment 3 chris fleizach 2021-10-18 08:49:40 PDT
Created attachment 441607 [details]
patch
Comment 4 Andres Gonzalez 2021-10-18 09:09:15 PDT
(In reply to chris fleizach from comment #3)
> Created attachment 441607 [details]
> patch

--- a/Source/WebCore/SourcesCocoa.txt
+++ a/Source/WebCore/SourcesCocoa.txt
@@ -255,6 +255,7 @@ platform/cocoa/ParentalControlsContentFilter.mm
 platform/cocoa/PasteboardCocoa.mm
 platform/cocoa/PasteboardCustomDataCocoa.mm
 platform/cocoa/PlatformPasteboardCocoa.mm
+platform/cocoa/PlatformSpeechSynthesizerIOS.mm @no-unify

Shouldn't this file be renamed to *Cocoa.mm now that is for both Mac and iOS?
Comment 5 chris fleizach 2021-10-20 08:22:32 PDT
Created attachment 441881 [details]
patch
Comment 6 chris fleizach 2021-10-20 19:43:29 PDT
Created attachment 441975 [details]
patch
Comment 7 chris fleizach 2021-10-21 09:06:15 PDT
Created attachment 442037 [details]
patch for landing
Comment 8 chris fleizach 2021-10-21 09:07:02 PDT
Created attachment 442038 [details]
patch for landing
Comment 9 EWS 2021-10-23 00:46:40 PDT
Committed r284742 (243451@main): <https://commits.webkit.org/243451@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442038 [details].
Comment 10 ayumi_kojima 2021-10-25 14:32:14 PDT
Reverted r284742 for reason:

Reverting because this commit may have casued a regression on imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-speak-events.html

Committed r284822 (243514@main): <https://commits.webkit.org/243514@main>
Comment 11 chris fleizach 2021-11-27 13:37:19 PST
Created attachment 445221 [details]
patch
Comment 12 chris fleizach 2021-11-27 13:40:01 PST
Created attachment 445222 [details]
patch
Comment 13 chris fleizach 2021-11-27 16:32:05 PST
Created attachment 445226 [details]
patch
Comment 14 chris fleizach 2021-11-27 16:33:56 PST
Created attachment 445227 [details]
patch
Comment 15 chris fleizach 2021-11-27 22:43:00 PST
Created attachment 445233 [details]
patch
Comment 16 EWS 2021-11-29 12:49:06 PST
Committed r286259 (244622@main): <https://commits.webkit.org/244622@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445233 [details].