Bug 234025 - [ANGLE] Code generation happens on each build and produces SCM diffs
Summary: [ANGLE] Code generation happens on each build and produces SCM diffs
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Keywords: InRadar
Depends on:
Reported: 2021-12-08 12:02 PST by Dean Jackson
Modified: 2021-12-09 07:35 PST (History)
7 users (show)

See Also:

Patch (2.61 KB, patch)
2021-12-08 12:04 PST, Dean Jackson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2021-12-08 12:02:18 PST
[ANGLE] Code generation happens on each build and produces SCM diffs
Comment 1 Dean Jackson 2021-12-08 12:04:49 PST
Created attachment 446403 [details]
Comment 2 EWS Watchlist 2021-12-08 12:06:35 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kimmo Kinnunen 2021-12-08 13:00:48 PST
Comment on attachment 446403 [details]

I'd imagine they need to be already checked into repo, as ANGLE doesn't run scripts compile time.
I'd also imagine run_code_generation.py could and should be fixed so that the output isn't nondeterministic.
Comment 4 Myles C. Maxfield 2021-12-08 17:37:23 PST
Comment on attachment 446403 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=446403&action=review

> Source/ThirdParty/ANGLE/ChangeLog:14
> +        We either need to generate these manually, or fix the Xcode project
> +        to generate them into Derived Sources so they don't appear in our
> +        repository.

Changing the Xcode project is what https://bugs.webkit.org/show_bug.cgi?id=233990 does.
Comment 5 EWS 2021-12-09 07:34:18 PST
Committed r286779 (245020@main): <https://commits.webkit.org/245020@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446403 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-09 07:35:20 PST