Bug 233990 - ANGLE modifies a source file every time you build
Summary: ANGLE modifies a source file every time you build
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-08 00:05 PST by Myles C. Maxfield
Modified: 2021-12-08 17:41 PST (History)
7 users (show)

See Also:


Attachments
Patch (45.27 KB, patch)
2021-12-08 00:13 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-12-08 00:05:23 PST
ANGLE modifies a source file every time you build
Comment 1 Myles C. Maxfield 2021-12-08 00:13:03 PST
Created attachment 446322 [details]
Patch
Comment 2 EWS Watchlist 2021-12-08 00:13:52 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Alexey Proskuryakov 2021-12-08 08:19:03 PST
Comment on attachment 446322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446322&action=review

> Source/ThirdParty/ANGLE/ChangeLog:20
> +        This patch adds a build step to copy all the generation script's input files into
> +        a DerivedSources/ directory, and copies the script there too, so the script thinks
> +        its inside the src/ directory, but it's actually not. Then, we can execute the
> +        script just like normal, except now it's producing a generated file inside the
> +        DerivedSources/ directory. This patch also adds the generated file to the Xcode
> +        project (but doesn't check in the file into the repo) so you can see its contents
> +        while editing, and project-wide searches will find it. This is the same design we
> +        use for the rest of WebKit's derived sources.

The aspect where we copy input files into DerivedSources isn't same design as the rest of WebKit. Is it intended as a temporary hack to overcome generation script's limitations?
Comment 4 Myles C. Maxfield 2021-12-08 14:34:00 PST
Comment on attachment 446322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446322&action=review

>> Source/ThirdParty/ANGLE/ChangeLog:20
>> +        use for the rest of WebKit's derived sources.
> 
> The aspect where we copy input files into DerivedSources isn't same design as the rest of WebKit. Is it intended as a temporary hack to overcome generation script's limitations?

Yes. The script has input and output paths hard coded and they both live in src/. So I think the only way to make it work is to copy the necessary files from src/ to DerivedSources/.
Comment 5 Myles C. Maxfield 2021-12-08 17:38:54 PST
Closing in favor of https://bugs.webkit.org/show_bug.cgi?id=234025