Bug 233881 - REGRESSION(r286535) [GTK] Fix clean builds after DerivedSources/WebKit2 move
Summary: REGRESSION(r286535) [GTK] Fix clean builds after DerivedSources/WebKit2 move
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-06 10:30 PST by Lauro Moura
Modified: 2021-12-06 19:41 PST (History)
9 users (show)

See Also:

Attachments
[fast-cq] Buildfix patch (3.03 KB, patch)
2021-12-06 10:31 PST, Lauro Moura 		no flags Details | Formatted Diff | Diff
[fast-cq] Updated patch addressing WPE (4.20 KB, patch)
2021-12-06 19:11 PST, Lauro Moura 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2021-12-06 10:30:26 PST 
REGRESSION(r286535) [GTK] Fix clean builds after DerivedSources/WebKit2 move
Comment 1 Lauro Moura 2021-12-06 10:31:40 PST 
Created attachment 446050 [details]
[fast-cq] Buildfix patch
Comment 2 EWS 2021-12-06 10:40:22 PST 
Committed r286549 (244880@main): <https://commits.webkit.org/244880@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446050 [details].
Comment 3 Myles C. Maxfield 2021-12-06 11:36:48 PST 
Sorry for causing this 😞 The EWS bots were green so I thought the rename was ready to go.
Comment 4 Lauro Moura 2021-12-06 11:51:35 PST 
(In reply to Myles C. Maxfield from comment #3)
> Sorry for causing this 😞 The EWS bots were green so I thought the rename
> was ready to go.

The EWS bots usually run incremental builds[1], triggering clean ones on failures. As the issue was actually happening on clean builds, this one flew under the EWS and post-commit bots radar.

Actually, it was the newly added GTK EWS layout test bots that raised the alarm, as the GTK EWS builder and EWS API testers are more stable and don't always do clean builds.

[1] IIRC, the `clean` in the checkout source step is related to `git clean` on the source tree, which ignores the build directory.
Comment 5 Lauro Moura 2021-12-06 18:54:59 PST 
Reopening to address WPE and a few GTK tweaks
Comment 6 Lauro Moura 2021-12-06 19:11:37 PST 
Created attachment 446110 [details]
[fast-cq] Updated patch addressing WPE
Comment 7 EWS 2021-12-06 19:41:23 PST 
Committed r286585 (?): <https://commits.webkit.org/r286585>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446110 [details].