Bug 233803 - Rename DerivedSources/WebKit2 to DerivedSources/WebKit
Summary: Rename DerivedSources/WebKit2 to DerivedSources/WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-03 00:21 PST by Myles C. Maxfield
Modified: 2021-12-06 10:39 PST (History)
11 users (show)

See Also:

Attachments
Patch (341.62 KB, patch)
2021-12-03 00:23 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (340.16 KB, patch)
2021-12-03 00:29 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (450.78 KB, patch)
2021-12-04 04:05 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (452.87 KB, patch)
2021-12-04 17:40 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-12-03 00:21:54 PST 
Rename DerivedSources/WebKit2 to DerivedSources/WebKit
Comment 1 Myles C. Maxfield 2021-12-03 00:23:54 PST 
Created attachment 445818 [details]
Patch
Comment 2 Tim Horton 2021-12-03 00:27:40 PST 
Good luck with the conflicts :)
Comment 3 Myles C. Maxfield 2021-12-03 00:29:59 PST 
Created attachment 445819 [details]
Patch
Comment 4 Tim Horton 2021-12-03 01:17:28 PST 
Comment on attachment 445819 [details]
Patch

rs=me
Comment 5 EWS 2021-12-03 01:31:43 PST 
Committed r286487 (244826@main): <https://commits.webkit.org/244826@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445819 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-03 01:32:21 PST 
<rdar://problem/86009014>
Comment 7 Robert Jenner 2021-12-03 12:24:00 PST 
Reverted r286487 for reason:

Broke multiple builds.

Committed r286508 (244846@main): <https://commits.webkit.org/244846@main>
Comment 8 Myles C. Maxfield 2021-12-04 04:05:34 PST 
Created attachment 445966 [details]
Patch
Comment 9 Myles C. Maxfield 2021-12-04 17:40:09 PST 
Created attachment 445972 [details]
Patch
Comment 10 Myles C. Maxfield 2021-12-04 19:36:38 PST 
Comment on attachment 445972 [details]
Patch

Okay, I made sure this builds correctly on Apple's internal build system and for OpenSource builds. I think this is ready to go.
Comment 11 EWS 2021-12-04 19:52:03 PST 
Committed r286535 (244867@main): <https://commits.webkit.org/244867@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445972 [details].