Bug 233865 - SourceBufferParser should be using contiguous shared buffer
Summary: SourceBufferParser should be using contiguous shared buffer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on: 233677
Blocks:
  Show dependency tree / graph
 
Reported: 2021-12-05 22:51 PST by Jean-Yves Avenard [:jya]
Modified: 2021-12-14 17:26 PST (History)
40 users (show)

See Also:

Attachments
Patch (17.14 KB, patch)
2021-12-05 23:25 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch for EWS (733.48 KB, patch)
2021-12-05 23:29 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch for EWS (736.61 KB, patch)
2021-12-07 01:34 PST, Jean-Yves Avenard [:jya] 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (17.71 KB, patch)
2021-12-14 16:50 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch (17.71 KB, patch)
2021-12-14 16:53 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2021-12-05 22:51:22 PST 
The SourceBufferParser uses SharedBuffer but assert that those contain a single segment at most.

Follow-up on bug 233677.
Comment 1 Radar WebKit Bug Importer 2021-12-05 23:06:52 PST 
<rdar://problem/86085253>
Comment 2 Jean-Yves Avenard [:jya] 2021-12-05 23:25:40 PST 
Created attachment 446004 [details]
Patch
Comment 3 Jean-Yves Avenard [:jya] 2021-12-05 23:29:51 PST 
Created attachment 446007 [details]
Patch for EWS
Comment 4 Jean-Yves Avenard [:jya] 2021-12-07 01:34:17 PST 
Created attachment 446137 [details]
Patch for EWS
Comment 5 Eric Carlson 2021-12-14 08:39:06 PST 
Comment on attachment 446004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446004&action=review

> Source/WebCore/ChangeLog:9
> +        Covered by existing tests, no observable differences.

It would be helpful to have a brief description of why this change was made here.
Comment 6 Jean-Yves Avenard [:jya] 2021-12-14 16:50:58 PST 
Created attachment 447178 [details]
Patch

Improve ChangeLog
Comment 7 Jean-Yves Avenard [:jya] 2021-12-14 16:53:48 PST 
Created attachment 447179 [details]
Patch

Add Reviewed-By line
Comment 8 EWS 2021-12-14 17:26:29 PST 
Committed r287059 (245255@main): <https://commits.webkit.org/245255@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447179 [details].