This is part 3 of bug 233030 and As per https://bugs.webkit.org/show_bug.cgi?id=233030#c40 SharedBuffer base class will be renamed FragmentedSharedBuffer ContiguousSharedBuffer will be renamed SharedBuffer
<rdar://problem/85963900>
Created attachment 445700 [details] WIP
Created attachment 445701 [details] WIP
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Created attachment 445834 [details] Patch for EWS
Created attachment 445838 [details] WIP
Created attachment 445849 [details] WIP
Created attachment 445850 [details] WIP
Created attachment 445929 [details] Patch for EWS
Created attachment 445931 [details] Patch
Created attachment 445947 [details] Patch for EWS
Created attachment 445971 [details] Patch for EWS
Created attachment 445998 [details] Patch Fix test failures
Created attachment 445999 [details] Patch for EWS
Created attachment 446006 [details] Patch for EWS
Comment on attachment 446006 [details] Patch for EWS this patch is for another bug
Created attachment 446026 [details] Patch for EWS rebase
Created attachment 446027 [details] Patch
Created attachment 446135 [details] Patch rebase
Created attachment 446136 [details] Patch for EWS rebase following changes in bug 233030
Created attachment 446153 [details] Patch for EWS
Comment on attachment 446153 [details] Patch for EWS webkit-patch is getting confused by those patch for EWS
Created attachment 446528 [details] Patch for EWS rebase
Created attachment 446535 [details] Patch for EWS rebase 2
Created attachment 446536 [details] Patch for review
Created attachment 447006 [details] Patch for EWS rebase
Created attachment 447007 [details] Patch for review
r=me once bots are happy
Created attachment 447077 [details] Patch fix bad earlier rebase
Created attachment 447083 [details] Patch ios build fix
Created attachment 447107 [details] Patch fix rebase error, side fix to GStreamerEMEUtilities and clients, checking for null
Comment on attachment 447107 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447107&action=review > Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:44 > +TEST_F(FragmentedSharedBufferTest, createWithContentsOfMissingFile) Are some of these tests worth being duplicated for SharedBuffer as well?
(In reply to youenn fablet from comment #32) > Comment on attachment 447107 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447107&action=review > > > Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:44 > > +TEST_F(FragmentedSharedBufferTest, createWithContentsOfMissingFile) > > Are some of these tests worth being duplicated for SharedBuffer as well? Thanks for the review. I don’t see much values in having extra tests specifically for contiguous buffer no.
Committed r287021 (245226@main): <https://commits.webkit.org/245226@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447107 [details].