Bug 233837 - [ANGLE] clang with -Wunknown-warning-option will fail on -Wweak-template-vtables
Summary: [ANGLE] clang with -Wunknown-warning-option will fail on -Wweak-template-vtables
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Keywords: InRadar
Depends on: 220896
  Show dependency treegraph
Reported: 2021-12-03 12:49 PST by Dean Jackson
Modified: 2021-12-15 10:09 PST (History)
9 users (show)

See Also:

Patch (1.79 KB, patch)
2021-12-03 12:52 PST, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2021-12-15 10:05 PST, Dean Jackson
graouts: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2021-12-03 12:49:48 PST
[ANGLE] clang with -Wunknown-warning-option will fail on -Wweak-template-vtables
Comment 1 Dean Jackson 2021-12-03 12:52:45 PST
Created attachment 445891 [details]
Comment 2 EWS Watchlist 2021-12-03 12:53:44 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kenneth Russell 2021-12-03 12:56:51 PST
Comment on attachment 445891 [details]

Looks fine, though please keep in mind this will collide with the big ANGLE upgrade Kyle's in the middle of in Bug 220896. Unless this is really pressing it might be better to wait for that to complete, but not sure how many blockers there are on that. r+
Comment 4 Dean Jackson 2021-12-03 13:00:15 PST
Agreed. This can wait until Kyle's roll lands, and maybe even come in the next roll if we can fix it upstream.
Comment 5 Kenneth Russell 2021-12-07 14:52:37 PST
Kyle's mega-roll landed in Bug 220896 - would it be feasible to upload this patch to ANGLE's code review tool instead, and pick it up by rolling forward ANGLE again?
Comment 6 Radar WebKit Bug Importer 2021-12-10 12:50:19 PST
Comment 7 Maciej Stachowiak 2021-12-14 12:27:20 PST
This is breaking a build internally so I'm not sure it can wait?
Comment 8 Kenneth Russell 2021-12-14 17:27:16 PST
Landing this now would be fine if it can't quickly/easily be uploaded to ANGLE's issue tracker. Kyle's landing a follow-on roll right now in Bug 234317 - but it doesn't include this fix.
Comment 9 Dean Jackson 2021-12-15 09:32:43 PST
An update on this. It seems I can't use __has_warning everywhere, so I'll try to add a new CFLAG for -Wno-unknown-warning-option
Comment 10 Dean Jackson 2021-12-15 10:05:30 PST
Created attachment 447250 [details]
Comment 11 Dean Jackson 2021-12-15 10:09:17 PST
Committed r287082 (245277@trunk): <https://commits.webkit.org/245277@trunk>