Bug 233726 – REGRESSION: r286075 [ Big Sur x86] 2 TestWebKitAPI.WebPushD (API-Tests) are constant failures

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Robert Jenner]

TestWebKitAPI.WebPushD.BasicCommunication
TestWebKitAPI.WebPushD.PermissionManagement

Are constant failures on BigSur Intel Macs only. 


HISTORY:
https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.WebPushD.BasicCommunication&test=TestWebKitAPI.WebPushD.PermissionManagement

TestWebKitAPI.WebPushD.BasicCommunication Failure:
        
        /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:183
        Value of: stringMatches
          Actual: false
        Expected: true
        
TestWebKitAPI.WebPushD.PermissionManagement Failure:
        
        /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:298
        Expected equality of these values:
          [origins count]
            Which is: 0
          1u
            Which is: 1
        
        
        /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:305
        Value of: [origin.get().protocol isEqualToString:@"testing"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:306
        Value of: [origin.get().host isEqualToString:@"main"]
          Actual: false
        Expected: true

[Radar WebKit Bug Importer]

<rdar://problem/85940164>

[Robert Jenner]

The initial regression point that broke these tests for Big Sur Intel only was r286075



However, it also appears that r286355 broke "TestWebKitAPI.WebPushD.BasicCommunication " everywhere else. There are mixed Failures/Timeouts on BigSur, and iOS 15

[Brady Eidson]

Fixing the truly broken test on all platforms, and also disabling on Mac.

[Brady Eidson]

Created attachment 445739 [details]
Patch

[EWS]

Committed r286440 (244784@main): <https://commits.webkit.org/244784@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445739 [details].