Add WKWebsiteDataStore configuration option to enable Mock app bundle testing As we add the real bundles to the platforms, will be useful to switch between explicitly enabling/disabling the mock one.
Created attachment 445515 [details] EWS v1
Comment on attachment 445515 [details] EWS v1 View in context: https://bugs.webkit.org/attachment.cgi?id=445515&action=review > Source/WebKit/NetworkProcess/NetworkSession.h:131 > + virtual bool webpushdUsesMockBundlesForTesting() const { return false; } Can we not call it "webpushd" in the code? webPushDaemon below seems a *tad* better, though still maybe not perfect. > Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h:90 > + WebPushD::WebPushDaemonConnectionConfiguration webPushDaemonConnectionConfiguration; Oh I see, you have ... already done it. Quite the name! > Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.h:62 > + WTFMove(*useMockBundlesForTesting), > + WTFMove(*hostAppAuditTokenData) These WTFMoves seem a bit unnecessary > Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:89 > +@property (nonatomic) BOOL webpushdUsesMockBundlesForTesting WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); Oof, surely not in the SPI though, please?
Created attachment 445531 [details] Patch for landing v1
For posterity: The Apple Silicon build failures were due to the patch in https://bugs.webkit.org/show_bug.cgi?id=233567 running right before this one in the EWS queue, and were not caused by this patch.
Committed r286355 (244714@main): <https://commits.webkit.org/244714@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445531 [details].
<rdar://problem/85912031>