Bug 233701 - Regression(r283912) Broke backward compatibility for Swift bindings
Summary: Regression(r283912) Broke backward compatibility for Swift bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 231496
  Show dependency tree / graph
 
Reported: 2021-12-01 07:27 PST by Chris Dumez
Modified: 2021-12-01 09:45 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.68 KB, patch)
2021-12-01 07:29 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-12-01 07:27:40 PST 
r283912 broke backward compatibility for Swift bindings.
Comment 1 Chris Dumez 2021-12-01 07:27:51 PST 
<rdar://85627701>
Comment 2 Chris Dumez 2021-12-01 07:29:55 PST 
Created attachment 445573 [details]
Patch
Comment 3 Darin Adler 2021-12-01 09:18:30 PST 
How do we *eventually* make this change? Is there any way to deprecate the old name and move to the new one over time?
Comment 4 Chris Dumez 2021-12-01 09:30:14 PST 
(In reply to Darin Adler from comment #3)
> How do we *eventually* make this change? Is there any way to deprecate the
> old name and move to the new one over time?

This is WebKitLegacy, do we really have to worry about updating it?
Comment 5 Darin Adler 2021-12-01 09:32:02 PST 
(In reply to Chris Dumez from comment #4)
> This is WebKitLegacy, do we really have to worry about updating it?

I see your point. I agree that we don’t.
Comment 6 EWS 2021-12-01 09:45:40 PST 
Committed r286367 (244726@main): <https://commits.webkit.org/244726@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445573 [details].