REGRESSION(r286205) [WinCairo] WebGL tests are failing Since r286205 (Bug 233515). > CONSOLE MESSAGE: WebGL: CONTEXT_LOST_WEBGL: loseContext: context lost > CONSOLE MESSAGE: *** Error: unable to create shader 'vshader' Buildbot: builder WinCairo-64-bit-WKL-Release-Tests build 3531 https://build.webkit.org/#/builders/60/builds/3531
WinCairo-64-bit-WKL-Debug-Tests is reporting assertion failures for WebGL tests. ASSERTION FAILED: Invalid enum returned from EGL_GetConfigAttrib false ..\..\Source\WebCore\platform\graphics\angle\GraphicsContextGLANGLE.cpp(92) : WebCore::GraphicsContextGLOpenGL::drawingBufferTextureTarget 1 00007FF8F99522CA WTFCrash 2 00007FF8DCB734EA WebCore::GraphicsContextGLOpenGL::drawingBufferTextureTarget 3 00007FF8DCD35A29 WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL 4 00007FF8DCD35F7F WebCore::GraphicsContextGLTextureMapper::GraphicsContextGLTextureMapper 5 00007FF8DCD35DF8 WebCore::GraphicsContextGLTextureMapper::create 6 00007FF8DCD352D7 WebCore::GraphicsContextGLOpenGL::create 7 00007FF8E05DA6E6 WebCore::GraphicsContextGL::create 8 00007FF8DFAE45C6 WebCore::WebGLRenderingContextBase::create 9 00007FF8DF8D0A3F WebCore::HTMLCanvasElement::createContextWebGL 10 00007FF8DF8D002F WebCore::HTMLCanvasElement::getContext 11 00007FF8DD717B30 WebCore::jsHTMLCanvasElementPrototypeFunction_getContextBody 12 00007FF8DD7228A9 WebCore::IDLOperation<WebCore::JSHTMLCanvasElement>::call<&WebCore::jsHTMLCanvasElementPrototypeFunction_getContextBody,0> 13 00007FF8DD7165D9 WebCore::jsHTMLCanvasElementPrototypeFunction_getContext 14 000001D98D6111BE Buildbot: builder WinCairo-64-bit-WKL-Debug-Tests build 1305 https://build.webkit.org/#/builders/32/builds/1305
Committed r286262 (244625@main): <https://commits.webkit.org/244625@main>
<rdar://problem/85834154>
Thanks! Later on, we should set the variable on GraphicsContextGLANGLE constructor. Do these tests not run on EWS?
WinCairo doesn’t have a EWS testing bot yet. If you want to test your patch before landing, let me know.